• src/xpdev/xpbeep.c

    From deuce@VERT to CVS commit on Thu Apr 16 02:25:04 2020
    src/xpdev xpbeep.c 1.99 1.100
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv12008

    Modified Files:
    xpbeep.c
    Log Message:
    Part two of xpbeep overhaul... remove duplicated code, fix leaks, fix
    races, etc.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Mon Apr 27 19:42:08 2020
    src/xpdev xpbeep.c 1.100 1.101
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv21901

    Modified Files:
    xpbeep.c
    Log Message:
    Fix some warnings.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Wed Apr 29 17:03:17 2020
    src/xpdev xpbeep.c 1.102 1.103
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv6227

    Modified Files:
    xpbeep.c
    Log Message:
    SDL needs a copy of the sample as well (ie: it keeps it around and free()s
    it itself)




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Fri May 1 09:43:54 2020
    src/xpdev xpbeep.c 1.103 1.104
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv10313

    Modified Files:
    xpbeep.c
    Log Message:
    Ignore the result of snd_pcm_drain() rather than waiting for it to work.
    Call snd_pcm_prepare() before every sample.

    Should fix bug #2
    https://sourceforge.net/p/syncterm/tickets/2/



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thu May 14 00:17:29 2020
    src/xpdev xpbeep.c 1.107 1.108
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv19922

    Modified Files:
    xpbeep.c
    Log Message:
    Only access PU from one thread because it's shit.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thu May 14 07:35:45 2020
    src/xpdev xpbeep.c 1.108 1.109
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv22647

    Modified Files:
    xpbeep.c
    Log Message:
    Remove debug printf()




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thu May 14 07:55:13 2020
    src/xpdev xpbeep.c 1.109 1.110
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv25184

    Modified Files:
    xpbeep.c
    Log Message:
    More rhobust pulseaudio fail-through.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thu May 14 09:54:30 2020
    src/xpdev xpbeep.c 1.110 1.111
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv26118

    Modified Files:
    xpbeep.c
    Log Message:
    I thought I removed this debug output already...




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thu May 14 11:57:27 2020
    src/xpdev xpbeep.c 1.111 1.112
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv12690

    Modified Files:
    xpbeep.c
    Log Message:
    xptone_open() is also a valid first call... put the pthread_once() in there
    as well.
    Fixes https://sf.net/p/syncterm/tickets/14/
    and https://sf.net/p/syncterm/tickets/16/




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thu May 14 14:12:10 2020
    src/xpdev xpbeep.c 1.112 1.113
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv4877

    Modified Files:
    xpbeep.c
    Log Message:
    Fix last commit for #ifndef XPDEV_THREAD_SAFE



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Mar 17 19:41:53 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/123f60d7afd45bf788bedf42
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix ALSA output on Linux

    It seems that the "real" ALSA will actually silently fail if you
    try to clear errors when no errors have occured. The FreeBSD
    emulation of ALSA does not have this insane requirement, so this
    went unnoticed for the 1.1 release.

    I suspect that this actually fixes SF bug 24, because ALSA is
    preferred over pulseaudio.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Mar 17 20:15:18 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/dc1d24b3b16cc0210c56cfd1
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Re-enable PulseAudio, ensure the handle is set to NULL on close.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Mar 18 05:58:31 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9f3d6e3a62fa3e288cdaf4
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Do what was likely intended by 8b6b7b7c

    The previous attempt completely disabled pulse audio.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Mar 18 10:24:32 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/e07b57962248e5cc907ca032
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    When trying to open pulse, play a millisecond of silence

    This allows the playback thread to open the device and errors to
    be checked. Otherwise, the first sound won't play.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Mar 18 10:25:58 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/e07d1380e650ce7992444f1f
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix bug in last commit (extra parameter)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Mar 18 10:27:14 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/0ef63571e50584c81e2e3da4
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Remove debug crap.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Mar 18 14:37:54 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/606762311f25c816bdb153ee
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix the single-threaded build:

    error: `handle_mutex' undeclared

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Fri Mar 19 07:05:12 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/d5e788518f41cbfddf9b3273
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix race condition when handle is opened by playing a sample.

    Caused a SyncTERM hang if it played a FG beep.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Feb 7 12:23:42 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/574712547b2d63bf5dcab0f9
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Another Windows warning about constiness.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sat Feb 10 21:49:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/2e2ab2510aa35d61fda176c1
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix some warnings.

    We can't use const protection for the sample buffer because the Win32
    API takes non-const buffers. For standard implicit conversions,
    simply disable the warning where it occurs on purpose. It appears
    that MSVC builds use the equivilent of -Wconversion (which isn't even
    part of -Wall).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Feb 10 22:10:30 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/1c47d84c7c55b6f6cffc0e06
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    _MSC_VER is the macro name you're looking for there :-)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sat Feb 10 22:28:17 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/abf1cd9ee46327a9d17cba0b
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Actually remove the const the comment says I can't have.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Feb 22 06:50:40 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/63cec349ee714376a2649e5f
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Remove need_copy variable when it won't be used.

    Fixes Coverity issue.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Feb 22 07:03:57 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ea42fffa92392454971c1cfd
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Keep pointers to dll_handle around to solence Coverity issues.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net