• src/sbbs3/scfgsave.c

    From rswindell@VERT to CVS commit on Sat Jul 28 11:27:00 2018
    src/sbbs3 scfgsave.c 1.75 1.76
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31801

    Modified Files:
    scfgsave.c
    Log Message:
    When attempting to create message base during config-save, make sure the
    full path to the data dir is created first (note: md() calls mkpath()). write_msgs_cfg() will now return FALSE if any message bases couldn't be created, but nobody is checking the return value currently.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Feb 14 11:06:00 2019
    src/sbbs3 scfgsave.c 1.76 1.77
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28051

    Modified Files:
    scfgsave.c
    Log Message:
    When saving message sub-boards and file directories to msgs.cnf/file.cnf,
    if any sub-boards or directories have *blank* names or internal code suffixes (a sign of a corrupted configuration), exclude them from the saved subs/dirs automatically. I'm not sure how this can happen (use of cnflib.js?) - but running "scfg -f" (force save) should fix this situation. For Android8675.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Feb 15 22:40:00 2019
    src/sbbs3 scfgsave.c 1.77 1.78
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24511

    Modified Files:
    scfgsave.c
    Log Message:
    Perform a similar elimination of invalid external program configurations
    (blank names or internal codes) from the total saved to xtrn.cnf.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jul 13 22:01:28 2019
    src/sbbs3 scfgsave.c 1.80 1.81
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16473

    Modified Files:
    scfgsave.c
    Log Message:
    Call prep_dir() (before md/mkdir) even when no file storage path is specified.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jul 13 22:53:18 2019
    src/sbbs3 scfgsave.c 1.81 1.82
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22685

    Modified Files:
    scfgsave.c
    Log Message:
    Refactor the transfer file path (storage directory) creation logic in write_file_cfg(). I'm pretty sure this fixes the bug introduced in r1.75 (Mar-7-2018) where it would use the directory's custom "data dir" as the
    parent of the sub-directory even if it was blank.

    So if you're like Mark Lewis and you're getting a bunch of sub-directories created in your "ctrl" directory when you save changes in SCFG, this is likely the cause. Only happened if you had both the library's "Parent Directory"
    and the "File Transfer Path" of the directory, blank.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jul 13 23:02:47 2019
    src/sbbs3 scfgsave.c 1.82 1.83
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25136

    Modified Files:
    scfgsave.c
    Log Message:
    Typo in previous commit: SAFECAT, not SAFECOPY!



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jul 13 23:10:08 2019
    src/sbbs3 scfgsave.c 1.83 1.84
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26145

    Modified Files:
    scfgsave.c
    Log Message:
    Add the "dirs" sub-folder (under data) to the last 2 commits.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Jul 14 15:13:35 2019
    src/sbbs3 scfgsave.c 1.84 1.85
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23467

    Modified Files:
    scfgsave.c
    Log Message:
    Fix bug in previous commit (this is getting a bit rediculous). Don't add the "dirs" sub-dir to a sysop-defined directory-specific data directory.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Aug 6 09:32:58 2019
    src/sbbs3 scfgsave.c 1.87 1.88
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31731

    Modified Files:
    scfgsave.c
    Log Message:
    Fix issue reported by Mark Lewis:
    scfg
    validates/creates directories when you save the file area config but they are
    missing the '/' between "dirs" and the internal code...

    So the Transfer File Path auto-default-value logic is actually in 3 places:
    - load_cfg.c prep_cfg()
    - scfgsave.c write_file_cfg()
    - scfgxfr2.c dir_cfg() - for display purposes only

    <sigh>


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 14 15:12:39 2020
    src/sbbs3 scfgsave.c 1.91 1.92
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1577

    Modified Files:
    scfgsave.c
    Log Message:
    smb_open_sub() will now create the msgbase if hasn't been created yet.

    I noticed that more than one caller of smb_open_sub() would not call smb_create() if the sub had not been previously "created" and in some of the instances where they did call smb_create(), if create failed, the message base was errorneously left open. So just do the create here to elmiinate the chance of error (forgetting) and redundancy of logic.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 14 15:27:39 2020
    src/sbbs3 scfgsave.c 1.92 1.93
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4188

    Modified Files:
    scfgsave.c
    Log Message:
    Use smb_fgetlength() instead of filelenth(fileno()).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 1 20:23:34 2020
    src/sbbs3 scfgsave.c 1.95 1.96
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14283

    Modified Files:
    scfgsave.c
    Log Message:
    Fix bug reported by WitNik (John):
    The msgbase 'status' header created with smb_open_sub() had all its fields 0-filled.
    This would cause all kinds of msgbase settings (e.g. max msgs, max age, etc.) to not propagate from their SCFG settings (for mail or sub-boards)
    to the newly-created msg base(s).
    But most importantly, it would cause the mail base to be created without the "EMail" attribute flag, causing the msgbase to be treated as a sub-board (public message area) and users could not then read their received mail.

    The root-cause was that smb_open() will zero-out the current smb.status
    value before trying to read it from the msgbase header, thus losing any
    values that were populated in there before calling smb_open(). Rather than change the behavior of the ancient smb_open() function, just restore the correct default smb.status values after calling smb_open() and before
    calling smb_create().


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Jun 14 19:09:25 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/04bb1bf85f50d42967a0cd4a
    Modified Files:
    src/sbbs3/scfgsave.c
    Log Message:
    Actually save the library's virtual sub-directory naming option value.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jan 22 17:39:44 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/cadada4df5a4752134329947
    Modified Files:
    src/sbbs3/scfgsave.c
    Log Message:
    Fix issue with QWKnet hub sub-board mappings when inserting new sub-boards

    The sub_t.subnum's that were being updated as message areas were being saved to msgs.ini could not be used as an index into the scfg_t.sub array at this point (the subnum would be the new index position when the msgs.ini was re-read/loaded)
    .

    This was not an issue in v3.19 because we just saved the subnum (to msgs.cnf) and
    in v3.20, we save the sub's internal code (to msgs.ini) and were using the newly
    updated sub_t.subnum to find the corresponding sub_t for that internal code. Since
    the subnum is not used now during the save process, no need to update it here (this reverses part of the commit 11e529d40bca40 from 5 years ago).

    This fixes issue #502 - thanks to the irc.synchro.netizens that reported it!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Feb 11 17:27:03 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/03b1f169ca63ad0c3f602f8f
    Modified Files:
    src/sbbs3/scfgsave.c
    Log Message:
    Fix bug where file.ini min_dspace could be set to -1

    min_dspace is an *unsigned* short, so saving 65535 (the default) was converting the signed decimal representation when saving file.ini.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net