1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/getnode.cpp

    From rswindell@VERT to CVS commit on Wed Jul 25 19:22:00 2018
    src/sbbs3 getnode.cpp 1.47 1.48
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv9612

    Modified Files:
    getnode.cpp
    Log Message:
    getnodedat() - don't try to unlock the node.dab file unless the read() fails. When using the MSVC2017 CRTL, an unlock() of a region that was not previously locked is a blocking call causing major slowness in the MSVC2017 build.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Jul 28 21:21:00 2018
    src/sbbs3 getnode.cpp 1.48 1.49
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31409

    Modified Files:
    getnode.cpp
    Log Message:
    The trigger to print a CRLF before claling putmsg() from getnmsg() and getsmsg() is now based on the current console column (!=0), not the current node action.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Mon Oct 8 21:33:00 2018
    src/sbbs3 getnode.cpp 1.51 1.52
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    getnode.cpp
    Log Message:
    Fix bug introduced in rev 1.49: cols is the number of terminal columns, not
    the current column number. Use the correct member variable name (column).



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 31 09:34:15 2019
    src/sbbs3 getnode.cpp 1.53 1.54
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11100

    Modified Files:
    getnode.cpp
    Log Message:
    sprintf->SAFEPRINTF replacements



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to Main/master on Mon Nov 23 17:12:10 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/840e27717857aa4af7221122
    Modified Files:
    src/sbbs3/getnode.cpp
    Log Message:
    Fix (restore previous) node action when forced into node-private-chat

    The current node action was not saved/restored when being forced into node-to-node private chat (by a sysop). This could lead to subsequent chat attempts by the same node to lead to a false indication that the nodes were chatting with each other.
    As reported by Altere (ATHEL).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Dec 13 13:23:16 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/2c818eb5ef3efceb37d03234
    Modified Files:
    src/sbbs3/getnode.cpp
    Log Message:
    Sync-up the node status flag output with presence_lib.js

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Aug 22 21:26:25 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e93b6dfa682e792f39c548dd
    Modified Files:
    src/sbbs3/getnode.cpp
    Log Message:
    Don't call utime() on the node.dab file for every read

    ... this was the cause of some observed unnecessarily high disk/file server (Samba) utilization, as we call getnodedat() a lot. utime() opens and closes the file, which was already open - and we're not modifying the file, so updating the 'modification time' here is wrong anyway.

    Disabling this 21-year old bit of logic resulted in a pretty dramatic
    reduction in Samba (smbd) CPU utilization on Vertrauen.

    If a BBS actually needes this hack (e.g. for NFS compatibility, as Deuce
    eluded in the comment), they'd be better off just setting the "Keep Node File Open" node setting (in SCFG->Nodes) to "No".

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on macOS)@VERT to Git commit to main/sbbs/master on Sat Nov 23 16:05:40 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/15e40a45a990d2a6d786ef22
    Modified Files:
    src/sbbs3/getnode.cpp
    Log Message:
    Fix potential deadlock in getnodedat(), observed on macOS

    Upon any node.dab lock or read failure, this code would cause errormsg() which would often/usually end up claling getnodedat() which would block forever trying
    to acquire the ndoefile_mutex (introduced in commit b9633069, I'm not clear why).

    Unlock/release the mutex *before* calling errormsg().

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Dec 2 00:29:20 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9bf541eadc1dadc9d7908d3b
    Modified Files:
    src/sbbs3/getnode.cpp
    Log Message:
    White-space changes only

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Dec 8 04:11:19 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/e7e90b9c496844b82b74e22e
    Modified Files:
    src/sbbs3/getnode.cpp
    Log Message:
    Reset/send status attr after activity, which could include Ctrl-A codes

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net