src/sbbs3 xtrn.cpp 1.229 1.230
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Resolve a couple GCC warnings:
unused variable 'p'
comparison between signed and unsigned integer expressions



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.230 1.231
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Fix build for USE_DOSEMU option (which I don't use).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Fri Apr 06 2018 00:08:37

xtrn.cpp
Log Message:
Fix build for USE_DOSEMU option (which I don't use).

I'm soryy, may I ask what the issues was? I use this option along with most of the time RELEASE=1 (my latest build was yesterday) The only issues I had with dosemu was changing the DOSEMU path in sbbs.ini. For some reason /usr/bin/dosemu.bin worked fine forever and about a month or so it just stopped working (im sure you remember my emails), So I said screw might as well just try "dosemu" as the value since I could pull dosemu from my cli with no issues, and it started working.

Would this have anything to do with that issue?

--

Tim Smith (KK4QBN)
KK4QBN BBS

---
* Synchronet * KK4QBN BBS - kk4qbn.com - 706.422.9538 - EM74OR - NW GA USA

Re: src/sbbs3/xtrn.cpp
By: KK4QBN to rswindell on Fri Apr 06 2018 08:38 am

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Fri Apr 06 2018 00:08:37

xtrn.cpp
Log Message:
Fix build for USE_DOSEMU option (which I don't use).

I'm soryy, may I ask what the issues was? I use this option along with most of the time RELEASE=1 (my latest build was yesterday) The only issues I had with dosemu was changing the DOSEMU path in sbbs.ini. For some reason /usr/bin/dosemu.bin worked fine forever and about a month or so it just stopped working (im sure you remember my emails), So I said screw might as well just try "dosemu" as the value since I could pull dosemu from my cli with no issues, and it started working.

Would this have anything to do with that issue?

No. There was a harmless warning when building withOUT USE_DOSEMU (unused variable defined) - I moved the variable definition into the block where it's used (the USE_DOSEMU stuff), but did it incorrectly which caused the build of xtrn.cpp to fail, temporarily.

digital man

Synchronet/BBS Terminology Definition #18:
DSZ = DOS Send ZMODEM (by Chuck Forsberg)
Norco, CA WX: 57.9øF, 81.0% humidity, 0 mph S wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.231 1.232
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17343

Modified Files:
xtrn.cpp
Log Message:
Removed an apparent debug-output (to stderr) line (output the path to emusetup.bat).
It was generating an (easy to fix) GCC 5.4.0 warning:
format not a string literal and no format arguments [-Wformat-security]
But the line was not needed, so just removed it.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: Digital Man to KK4QBN on Fri Apr 06 2018 23:48:56

No. There was a harmless warning when building withOUT USE_DOSEMU (unused variable defined) - I moved the variable definition into the block where it's used (the USE_DOSEMU stuff), but did it incorrectly which caused the build of xtrn.cpp to fail, temporarily.

Ahh ok, I'm still vexed as to why my dosemu games will not work when I put the full path and filename to dosemu.bin in sbbs.ini instead of just 'dosemu' it works so thats fine.. but its just strange that using it the 'correct' way worked for close to 2 years, then suddenly I started getting close to 50 errors daily and find that my DOS doors are not working, a lot of the errors were even errors becaus teh DOS events I had setup for processing league packets were erroring out and then backing up the other events so they would'nt run, one big huge domino effect.

I still to the day do'nt know why I have to run dosemu like that, but since I changed it, all errors have gone away and everything is running smooth.

--

Tim Smith (KK4QBN)
KK4QBN BBS

---
* Synchronet * KK4QBN BBS - kk4qbn.com - 706.422.9538 - EM74OR - NW GA USA

src/sbbs3 xtrn.cpp 1.232 1.233
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv32518

Modified Files:
xtrn.cpp
Log Message:
Experimental enhancement: enable WWIV color (Ctrl-C) code expansion in *nix-builds (for stdio WWIV doors).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.233 1.234
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13808

Modified Files:
xtrn.cpp
Log Message:
Fix FreeBSD build, broken by revision 1.230




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.234 1.235
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv32165

Modified Files:
xtrn.cpp
Log Message:
Add clarification to the "No startup directory" error, that this is only
for DOS programs (part of the USE_DOSEMU patch).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Thu Jun 21 2018 13:23:44

Great addition ;)

Marisa
--- https://AmigaCity.xyz - Portal for the Amiga - More than 2,600 free DLs
--- https://AmigaCityLaptops.com - Laptops & Handhelds that run AmigaOS
--- https://AmigaCity.xyz/radio.html - Amiga game music 24/7
--- https://BBSlist.SynchronetBBS.org - Active BBS List for all BBS types
--- https://SynchronetBBS.org/OurServers - A list of all our websites
--- https://gamenet.SynchronetBBS.org - GameNet BBS Network
þ Synchronet þ Amiga City - The BBS for the Amiga - more than 2,500+ files

Re: src/sbbs3/xtrn.cpp
By: Marisag to rswindell on Sat Jun 23 2018 02:54 am

Great addition ;)

Please quote the part of the message you're repying to. What exactly is a great addition?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: src/sbbs3/xtrn.cpp
By: Nightfox to Marisag on Sun Jun 24 2018 22:20:08

Please quote the part of the message you're repying to. What exactly is a great addition?

Sorry, I was commenting on that change that was made due to my request ;)

Marisa
--- https://AmigaCity.xyz - Portal for the Amiga - More than 2,600 free DLs
--- https://AmigaCityLaptops.com - Laptops & Handhelds that run AmigaOS
--- https://AmigaCity.xyz/radio.html - Amiga game music 24/7
--- https://BBSlist.SynchronetBBS.org - Active BBS List for all BBS types
--- https://SynchronetBBS.org/OurServers - A list of all our websites
--- https://gamenet.SynchronetBBS.org - GameNet BBS Network
þ Synchronet þ Amiga City - The BBS for the Amiga - more than 2,500+ files

src/sbbs3 xtrn.cpp 1.236 1.237
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6996

Modified Files:
xtrn.cpp
Log Message:
Another eprintf to lprintf change.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.239 1.240
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Improved error log messages:
- include errno description (strerror output)
- exclude (redundant) node number



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.240 1.241
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15059

Modified Files:
xtrn.cpp
Log Message:
Fix multiple potential buffer overflows in external() (for Windows) with "overly long" cmdlines.
Also fixed a bug (for Windows) where external() would return 0 (success) even when CreateProcess() fails - must re-restore the "last_error" value before returning.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.241 1.242
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Linux-DOSEMU patch fix:
Use case-insensitive check of executable file extension for ".bat".
The obvious "fix" would have been to use strcasestr() instead of strstr(),
but that would leave the unlikely corner case of x.bat.exe producing a false-positive, for example. Use the proper functions for getting a file extension and performing a full case-insensitive string compare.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.242 1.243
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12690

Modified Files:
xtrn.cpp
Log Message:
Replace all occurences of unsafe strcat() calls with strncat() in sbbs_t::cmdstr() and cmdstr().


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.243 1.244
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
xtrn.cpp
Log Message:
Fix missing param in last commit (for *nix builds only).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.244 1.245
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7517

Modified Files:
xtrn.cpp
Log Message:
Patch from Mark Lewis (wk42):

i've made a few adjustments to xtrn.cpp for external.bat...

- remove unneeded redirection of dosemu output.
still uses same log file name and stops zero
byte file dosemu.log from being created in node
directories.
- fix faulty "keystroke" dosemu -I command. it
didn't actually do the "\r" but sent it as
characters to the command line.
- added code for SBBS specific lredirs to be
done more cleanly like dosemu's default
autoexec.bat. only deletes redir if it exists.

His editor also appears to have removed trailling white-space from this file, which is fine.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.246 1.247
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9146

Modified Files:
xtrn.cpp
Log Message:
Fix the missing carriage-returns in the shell (bash) prompts by always building with the stderr logging
support (in *nix builds) - but run-time disable as desired via EX_NOLOG option. I've been wanting to get
rid of that "XTERN_*" macro for a long time anyway (it's "XTRN" damn-it!). :-)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.247 1.248
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27921

Modified Files:
xtrn.cpp
Log Message:
Log a warning or error if an external program is attempted to be executed but can't because it's a DOS program and the current node doesn't support it.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.248 1.249
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24309

Modified Files:
xtrn.cpp
Log Message:
Pipe non-binary external program output through rputs() so we get charset translation "for free". Windows only for now.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.251 1.252
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19890

Modified Files:
xtrn.cpp
Log Message:
When the passthru_thead is running, the protocol (%p) command-line specifier will now expand to "raw" rather than "telnet/rlogin/ssh". This disables IAC handling in sexpots, for example, which isn't needed or desired when using
the passthru socket.

Also, put some conditional checks for passthru_thread_running in external()
and if it's not (e.g. for testing purposes), then lock the input_thread_mutex instead of changing passthru_socket_active. This is currently just a way to easily test the differences between direct and passthru socket I/O
(dependant on whether or not the passthru_thread is running which is controlled in main.cpp.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/xtrn.cpp
By: rswindell to CVS commit on Wed Aug 21 2019 11:31 am

When the passthru_thead is running, the protocol (%p) command-line specifier will now expand to "raw" rather than "telnet/rlogin/ssh". This disables IAC handling in sexpots, for example, which isn't needed or desired when using the passthru socket.

Course I meant to say "sexyz", not "sexpots". I seem to be conflating those two stupid program names more often latey.

digital man

Synchronet/BBS Terminology Definition #36:
HTTPS = Secure HTTP (authenticated and encrypted HTTP over TLS)
Norco, CA WX: 87.9øF, 31.0% humidity, 6 mph E wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.252 1.253
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3213

Modified Files:
xtrn.cpp
Log Message:
Use the telnet_expand() from telnet.c now.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.256 1.257
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28552

Modified Files:
xtrn.cpp
Log Message:
In *nix builds, change the second almost identical log "Executing external"
log message to:
- only log the message if the "full command line" is different than the
command-line argument to the external() function. I'm pretty sure that was
the reason for the addition of this log message, for debugging Linux-DOSEMU
issues where the fullcmdline != cmdline.
- change from INFO to DEBUG log level
- change the message from "executing external: " to "Executing cmd-line: "



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.257 1.258
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18464

Modified Files:
xtrn.cpp
Log Message:
Add missing environment variables in *nix builds when spawning native programs: YEAR, MONTH, MONTHNAME, WEEKDAY, DAY


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.258 1.259
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27971

Modified Files:
xtrn.cpp
Log Message:
%s is also used for the startup directory


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.259 1.260
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8024

Modified Files:
xtrn.cpp
Log Message:
Added 2 new environment variables dynamically-defined when launching DOS programs: PCBDRIVE (the drive letter of the current node directory) and PCBDIR (the path to the current node directory, without the drive letter).

These emulate the same variables crated by PCBoard.

The reason these are being added is that Sunrise Door Software's 16-bit doors contain special support for these environment vars when used in their .CFG files
(e.g. %PCBDIR%DOOR.SYS) and this allows easy multi-node configuration with a single .CFG file. The SBBSNODE environment varialbe would have worked perfectly fine for this purpose, but apparently Sunrise Doors (or the DoorFrame development kit they utilized) has hard-coded these PCBoard (and Wildcat!) environment variable names, so SBBSNODE wont' work for this purpose.

For Synchronet-Win32, you will need the DOSXTRN.EXE revision 25 or later
or you may experience NTVDM crashes when running external DOS programs.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 xtrn.cpp 1.262 1.263
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16614

Modified Files:
xtrn.cpp
Log Message:
Add support for %^ command-line specifer which expands to the system architecture (e.g. "i686" for Win32 builds, "x64" for Linux-x86_64 builds).
Currently, there underlying XPDEV macro definition does not differentiate between arm32 and arm64, but it should. Next...


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ec5cbb848bc16419cc4267a9
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix compile issue in previous commit. Add more semicolons.

One can't have too many semicolons.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ccf41a4c15bfdbb1b1aa46d3
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Don't log blank lines output from external programs on *nix

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e2a9066d89af60010e8bf55b
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix Linux-DOSEMU buffer overflow warnings with sprintf() usage (!!!)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8312547f3d4e276ac722b7df
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Trim left-most whitespace from stderr lines of externals before logging.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ca424956d4f80d5d313b7eca
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Don't do the special DOSEMU cmdline specifier magic if the cmd starts with '?'

JavaScript modules are intuitively "native" and have not historically required the "native" option to be set to "yes" in SCFG.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/02a967b2403024c0a572eb45
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Trim white-space from the start of stderr-logged string from xtrns

... like the last commit that did this, but do in the other 2 places where stderr output is logged as log messages.
Also, include the extended program name in the stderr log messages, making it easier to find the output you're looking for.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5a1ab6a7e8040e06aecf3868
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
A second pass at: Better native vs. DOS cmd-line detection in cmdstr()

cmdstr() is often called for non-executable command-lines (e.g. for @include: file name/path arguments), so don't default to native unless a mode value was specified. Hopefully addresses issue reported by bobrob without breaking anything else (again).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/87926cdac705ac979c403a5d
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix new GCC warning about unused variable.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0e6853aeef28d32a26bc2c46
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Correctly support 1,000 arguments to an external

Previously, more than 999 arguments would overrun a buffer and break
things.

Fixes CID 33313

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7505f317f5581340ed1a9f60
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix use of uninitialized local variable (err_pipe[]) on *nix

And other weirdness around EX_NOLOG mode checks.
Addresses Coverity-scan CID 330048.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9445866c80a38b5ee6c170ea
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Ignore VDD WriteFile() failures if the child process has terminated

If the child process (e.g. door game) has terminated, don't log errors if/when WriteFile() to the mailslot fails. This would be expected as the mailslot is created/owen-by sbbsexec.dll which would also terminate along with the process, thus closing the mailslot.

Hopefully resolves the errors reported by DesotoFireflite (VALHALLA).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/08ce315f97a09569f169ef89
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Suppress "VDD Open failed" warning if child process terminated

Another log message reported by DesotoFireflite (VALHALLA) that can happen when a user has typed something while the programming is running and the program terminates before the data can be sent to it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/47e604723eb6eb602ed7e463
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
When running 16-bit DOS commands "offline" on Windows, don't use dosxtrn

We shouldn't need a virtual UART/FOSSIL driver to execute "offline" program (e.g. timed events) in the first place, and our virtual UART/FOSSIL for Windows wouldn't work right in the scenario anyway even if it did load successfully.

This resolves the reported issues with timed events configured as not "native" returning error 255 (and not running successfully) on Windows with SBBS v3.19. I'm not even sure what changed exactly in xtrn.cpp, dosxtrn.c, and sbbexec.c between v3.18 and v3.19 that's causing this to now fail, but it (using DOSXTRN to run offline DOS programs) really shouldn't have been attempted in the first place. So that was just a design issue that happened to kind of sort of work up until v3.19.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e54263fde0be580dcbaf77c8
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Log command-line that led to logged error opening DOSXTRN.RET

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/280f16f4f373956c17d2a5eb
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Add EXECDIR, DATADIR, and XTRNDIR to DOSemu command replacement tokens

As requested. This closes issue #416

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ce475f794e112fa9c9f435c6
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Don't log error opening DOSXTRN.RET when terminating an external

If we detect a client disconnection and terminate DOSXTRN.EXE, don't try to open DOSXTRN.RET and log an error when the file doesn't exist (as would be expected).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e7109c87bc43f21636c5f981
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
When user hangs-up on external programs on *nix, try to terminate w/SIGTERM

Previously, when a user disconnected or ran out of time while running a stdio-based external program on *nix, if the program was still running, we'd send it a SIGHUP, wait up to 10 seconds for the process to terminate and if
it did not, terminate it (ungracefully) with SIGKILL. Since some programs
catch SIGTERM (and not SIGHUP) to indicate a termination request, we now will first attempt a SIGHUP, wait up to 5 seconds for the process to terminate and if it does not, then send a SIGTERM and wait up to another 5 seconds for it
to terminate and if it doesn't, then finally send it a SIGKILL (which cannot
be caught and always results in an ungraceful termination of the child process).

This doesn't resolve any specific problem with any specific stdio-based external program, but I was playing around with ESR's port of Adventure (https://gitlab.com/esr/open-adventure) and a new auto-save/restore of game state and noticed that we weren't using SIGTERM for this situation, though we should have. Most modern programs, if they catch SIGHUP at all, use it to indicate a refresh of configuration or data files, not a termination request (or indication that a user has "hung up"). So SIGTERM is more reasonable to be expected to be caught and initiate the graceful termination of the child program that we're hoping for.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f78a70986d1e3b21b09ca32e
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix name of data event

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/23513871ebc07d81e7cb83d8
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
0-init the 'gamedir' variable

Resolves CID 434888, not sure why this one didn't show up before.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/47773812d5d779c3a2d5466a
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Eliminate unsafe sprintf calls (replaced with snprintf) in *nix build

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/90de66ac9910333dfdf76d98
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Move the startup directory checking to the "native" block of *nix build

of sbbs_t::external()

The startup directory for DOS doors might not be a valid Unix (case-sensitive) path, so let's just do that check in the native block here.

Also, removed a bunch of redundant startup_dir ==/!= NULL checks. It can't be NULL here.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/241475effe9d6c09d677b323
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Since on at least Debian 12.4, the ttydefaults array is completely
wrong, do c_cc the stupid (but POSIXly correct) way with a billion
supporting.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d1642fb88cf3d8ac38c6d8e2
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Explicitly initialize c_cc to _POSIX_VDISABLE since we can't know
that we're setting all the values anymore. :(

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9db2d372ed865d17b7fb4ce2
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Don't use i for loop index since it's signed.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/40280934edd931d5d3516b7e
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Convert CP437 to UTF-8 (when necessary) for *nix stdio doors (e.g. DOSEMU)

... as requested by "ben" in #synchronet at irc.synchro.net

Currently, this assumes all stdio doors aren't "UTF-8 native", which might be an incorrect assumption.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5277021c97929fc46c742093
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix GCC-aarch64 compile (caught be pipeline)

error: cannot bind non-const lvalue reference of type `long unsigned int&' to an rvalue of type `long unsigned int'

Just getting rid of more use of ulong (replaced with size_t).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/da313d28ca8be77e28f96d8e
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Fix MSVC compiler issues introduced in previous commit

And use DWORD insteaad of 'unsigned long' where specified by Win32 API.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76fa22e427a7b9978084bf94
Modified Files:
src/sbbs3/xtrn.cpp
Log Message:
Remove lprintf() call from child process of fork() call on *nix

the info-level debug message "Detaching external process"... as this appears
to be the cause of background events hanging sometimes, on Linux (at least).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net