-
src/sbbs3/websrvr.c
From
rswindell@VERT to
CVS commit on Thu Apr 5 15:23:00 2018
src/sbbs3 websrvr.c 1.665 1.666
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
websrvr.c
Log Message:
Enabled GCC-assisted printf-style format/arg checking for lprintf() and
fix the resulting warnings.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Mon Apr 30 19:00:00 2018
src/sbbs3 websrvr.c 1.667 1.668
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20001
Modified Files:
websrvr.c
Log Message:
Break the loop when failed is set to true.
Also, use a stack pointer if the passed failed pointer is NULL.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sat Oct 6 11:34:00 2018
src/sbbs3 websrvr.c 1.668 1.669
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14230
Modified Files:
websrvr.c
Log Message:
zero-initialize the msg-scan (subscan) allocated array, so if an uninitialized is ever written to disk, it'll be zeroes not garbage.
Also, NULL the subscan pointer after freeing (and don't free if it's NULL).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed Dec 5 13:17:00 2018
src/sbbs3 websrvr.c 1.670 1.671
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2663
Modified Files:
websrvr.c
Log Message:
Added TODO comment regarding apparent RFC 2145 violation in the Status-Line HTTP-Version value we send (no functional change). My intepretation is we should be sending either nothing or "HTTP/1.1" here, never "HTTP/1.0". This interpretation appears to match the behavior of other web servers
(e.g. Apache httpd).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Thu Dec 6 10:29:00 2018
src/sbbs3 websrvr.c 1.671 1.672
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23667
Modified Files:
websrvr.c
Log Message:
Added TODO comment regarding the lack of a Content-Length header field
in GET responses when Connection: Keep-Alive is not enabled.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Tue Dec 18 05:25:00 2018
src/sbbs3 websrvr.c 1.672 1.673
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9577
Modified Files:
websrvr.c
Log Message:
1xx, 204, and 304 responses don't include an entity.
If we get one of these statuses from via a CGI, assume we have good headers.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Tue Dec 18 07:53:00 2018
src/sbbs3 websrvr.c 1.673 1.674
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1995
Modified Files:
websrvr.c
Log Message:
Header field values may (usually do) have leading linear white-space, so
skip any spaces before parsing the value (for CGI supplied headers).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Mon Dec 31 15:38:00 2018
src/sbbs3 websrvr.c 1.674 1.675
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25689
Modified Files:
websrvr.c
Log Message:
Fixed typo: deprecated, not depreciated.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Fri Jan 4 10:18:00 2019
src/sbbs3 websrvr.c 1.675 1.676
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29102
Modified Files:
websrvr.c
Log Message:
Fixed typo in error message.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed May 22 11:39:25 2019
src/sbbs3 websrvr.c 1.680 1.681
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23025
Modified Files:
websrvr.c
Log Message:
open_post_file(): if post_data is NULL, just log an error and return NULL (don't pass a NULL pointer to fwrite() which can assert or crash).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed May 22 13:40:03 2019
src/sbbs3 websrvr.c 1.681 1.682
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8139
Modified Files:
websrvr.c
Log Message:
Increase MAX_POST_LEN from 1MB to 4MB (QWK REP packets can be > 1MB) -
I think that > 1MB post data is supported, but the http_request.post_data
property won't be created if the length > MAX_POST_LEN. Perhaps would just
store the post data in a file (uh, it already is?) and expose the filename to
JS scripts? It'd be a lot cleaner than storing the data in a file and then
reading (or mem-mapping) the file and then copying the contents into a JS
property.
Allow the JS http_request.post_data property to contain NULs.
open_post_file() will now open the post file (and return the FILE*) even if
session->req.post_data is NULL, it just won't try to write to the file if the
post_data is NULL.
mem-map the large post data files using XPMAP_WRITE (read/write) rather than
XPMAP_READ (read-only) - without this change, this line in read_post_data()
would cause an exception:
session->req.post_data[session->req.post_len]=0;
Now, we seem to have the potential of an off-by-one here (if the length
mem-mapped is not post_len + 1), but that isn't happening. <shrug>
Fixed a couple of FILE pointer/descriptor leaks if post_to_file() failed.
Changed name of post data file to SBBS_POST.*.*.data (it's not necessarily html).
So now, uploads > 1MB work, but questions remain:
- wouldn't PUT be a more appropriate method (than POST) for file uploads?
- how can we support post_data > MAX_POST_LEN (now 4MB) in JS?
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Fri Jun 7 08:46:47 2019
src/sbbs3 websrvr.c 1.682 1.683
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
websrvr.c
Log Message:
Fix observed segfault (NULL pointer dereference) in parse_headers
(strtok can return NULL).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Jun 21 07:54:31 2019
src/sbbs3 websrvr.c 1.684 1.685
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8336
Modified Files:
websrvr.c
Log Message:
Some RFC nits.
1) Send Content-Length even if we will be closing the connection.
2) Send the highest HTTP version in the status line that has the same major version.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Tue Jul 2 18:17:49 2019
src/sbbs3 websrvr.c 1.686 1.687
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27170
Modified Files:
websrvr.c
Log Message:
send_headers() is called twice for chunked data. The second time is required for additional headers and the final terminating CRLF.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Wed Jul 3 14:53:30 2019
src/sbbs3 websrvr.c 1.687 1.688
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4323
Modified Files:
websrvr.c
Log Message:
As with CGI, if a script specifies a Content-Length or Transfer-Encoding header, don't calculate either one and let the script shoot itself in the
foot.
Also, if a Location header is set, try an internal redirect rather than
forcing the client to handle it.
Now scripts can avoid chunked mode by specifying a correct content-length
if the content-length is wrong though, Bad Things will happen.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Wed Jul 3 14:57:42 2019
src/sbbs3 websrvr.c 1.688 1.689
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4962
Modified Files:
websrvr.c
Log Message:
Update to last commit... only allow fiddling with things if the initial
headers haven't been sent yet.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Tue Jul 23 21:52:19 2019
src/sbbs3 websrvr.c 1.690 1.691
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15156
Modified Files:
websrvr.c
Log Message:
Store the configured temp directory for the web server in scfg.temp_dir so that JS scripts using system.temp_dir to store files get a sensible value (and not the hard-coded default of just "temp").
This should fix the creation of ctrl/tempftelnet.url files.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Aug 2 06:10:08 2019
src/sbbs3 websrvr.c 1.691 1.692
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18463
Modified Files:
websrvr.c
Log Message:
Fix an error nobody has ever seen.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Aug 2 06:26:09 2019
src/sbbs3 websrvr.c 1.692 1.693
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20335
Modified Files:
websrvr.c
Log Message:
Add a terrible hack to see if the TLS POST issue is what I think it is.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Aug 2 06:47:07 2019
src/sbbs3 websrvr.c 1.693 1.694
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23121
Modified Files:
websrvr.c
Log Message:
De-hack and maybe fix?
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Aug 2 06:50:36 2019
src/sbbs3 websrvr.c 1.694 1.695
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23687
Modified Files:
websrvr.c
Log Message:
Don't crash of rd is NULL.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Aug 2 06:52:02 2019
src/sbbs3 websrvr.c 1.695 1.696
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23917
Modified Files:
websrvr.c
Log Message:
Better anti-crash behaviour.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Nightfox@VERT/DIGDIST to
deuce on Fri Aug 2 08:56:33 2019
Re: src/sbbs3/websrvr.c
By: deuce to CVS commit on Fri Aug 02 2019 10:10 am
websrvr.c
Log Message:
Fix an error nobody has ever seen.
Thanks for fixing that. I was waiting for that fix. ;)
Nightfox
---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com
-
From
rswindell@VERT to
CVS commit on Fri Aug 2 11:20:38 2019
src/sbbs3 websrvr.c 1.696 1.697
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
websrvr.c
Log Message:
Remove unused variable in session_check()
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Fri Aug 23 10:08:22 2019
src/sbbs3 websrvr.c 1.697 1.698
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13821
Modified Files:
websrvr.c
Log Message:
login() naw calls badlogin() upon login failure.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Mon Sep 2 15:19:01 2019
src/sbbs3 websrvr.c 1.698 1.699
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18232
Modified Files:
websrvr.c
Log Message:
Alterego reported a scenario where the web server's cleanup() would wait forever for 1 child thread (presumably the http_logging_thread) to terminate:
8/27 02:39:43p Waiting for HTTP logging thread to terminate...
8/27 02:39:43p HTTP logging thread started
8/27 02:39:43p HTTP logging thread received NULL linked list log entry
8/27 02:40:44p !TIMEOUT waiting for HTTP logging thread to terminate
8/27 02:40:44p Done waiting for HTTP logging thread to terminate
8/27 02:40:44p 0000 Waiting for 1 child threads to terminate
<infinite wait loop here>
- Add an extra terminate_http_logging_thread check to the top of the loop in
http_logging_thread().
- Signal the log_list semaphore in the "Waiting for HTTP logging thread" and
"Waiting for x child threads" loops.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sun Oct 20 19:32:30 2019
src/sbbs3 websrvr.c 1.699 1.700
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
websrvr.c
Log Message:
Fix buffer (stack memory) overflow observed in parse_headers(). This is what brought down [cvs.]synchro.net this weekend. It's hard to believe we still
have unchecked calls sprintf() around, but we do.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Jan 3 07:35:42 2020
src/sbbs3 websrvr.c 1.700 1.701
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23416
Modified Files:
websrvr.c
Log Message:
Allow redirects from non-existant URLs.
This allows redirect targets from paths that don't exist. Required to implement hard-coded API endpoints via ssjs.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Thu Jan 23 04:27:47 2020
src/sbbs3 websrvr.c 1.701 1.702
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16639
Modified Files:
websrvr.c
Log Message:
While we're making ssllabs happy, disable TLS 1.0 and 1.1 in the web server only (you can still use them from JS etc).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Fri Jan 24 05:38:37 2020
src/sbbs3 websrvr.c 1.702 1.703
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13539
Modified Files:
websrvr.c
Log Message:
Comment out TLS 1.2 minver. Too many existing things don't support 1.2.
We don't need PCI DSS compliance I hope, we just want people doing things.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Tracker1@VERT/TRN to
deuce on Sun Jan 26 03:10:02 2020
Re: src/sbbs3/websrvr.c
By: deuce to CVS commit on Thu Jan 23 2020 09:27:47
For what it's worth, we've been using the following list of ciphers where I work... seems to have decent security/compatibility currently.
ECDHE-ECDSA-AES128-GCM-SHA256
ECDHE-RSA-AES128-GCM-SHA256
ECDHE-ECDSA-AES256-GCM-SHA384
ECDHE-RSA-AES256-GCM-SHA384
ECDHE-ECDSA-CHACHA20-POLY1305
ECDHE-RSA-CHACHA20-POLY1305
DHE-RSA-AES128-GCM-SHA256
DHE-RSA-AES256-GCM-SHA384
--
Michael J. Ryan
+o roughneckbbs.com
bbs@tracker1.dev
---
þ Synchronet þ Roughneck BBS - coming back 2/2/20
-
From
rswindell@VERT to
CVS commit on Thu Mar 5 07:22:46 2020
src/sbbs3 websrvr.c 1.703 1.704
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
websrvr.c
Log Message:
Fix NULL pointer dereference in CGI handling:
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007fb3be8ce071 in do_cgi_stuff (session=0x7fb2fbfaac40, cgi=0x7fb2fbfaa850, orig_keep=1) at websrvr.c:4376
4376 SKIP_WHITESPACE(value);
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Tue Mar 10 14:07:32 2020
src/sbbs3 websrvr.c 1.705 1.706
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12695
Modified Files:
websrvr.c
Log Message:
Since lprintf() sends to stdout in sbbscon foreground mode, we must call
it before redirecting stdout to the pipe.
Likely fixes CGI errors seen by alterego (and has been broken for almost fifteen years).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Tue Mar 10 14:51:06 2020
src/sbbs3 websrvr.c 1.706 1.707
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19117
Modified Files:
websrvr.c
Log Message:
Move lprintf() out of fork() child... it uses a mutex and the state of
mutexes are undefined in children.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Sat Apr 4 21:04:47 2020
src/sbbs3 websrvr.c 1.708 1.709
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2052
Modified Files:
websrvr.c
Log Message:
Support CGI over TLS on *nix.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Sat Apr 4 23:01:24 2020
src/sbbs3 websrvr.c 1.709 1.710
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24259
Modified Files:
websrvr.c
Log Message:
Don't attempt to read a FastCGI body if the header type is zero.
Should fix the POST/GET hangs on the wiki once DigitalMan updates.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Sun Apr 5 09:29:09 2020
src/sbbs3 websrvr.c 1.710 1.711
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22341
Modified Files:
websrvr.c
Log Message:
Add some paranoia for handling FCGI_END_REQUEST.
While the FastCGI read_wait_timeout function should never return
CGI_*_READY with CGI_PROCESS_TERMINATED, it looks like somehow on some
systems, there's an additional select() happening after the process is
done.
Explicitly track this, and try to prevent it.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Sun Apr 5 10:15:21 2020
src/sbbs3 websrvr.c 1.711 1.712
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv757
Modified Files:
websrvr.c
Log Message:
Fix bug in last commit... !
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Sun Apr 5 11:12:21 2020
src/sbbs3 websrvr.c 1.712 1.713
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4082
Modified Files:
websrvr.c
Log Message:
Just because there is a Location: header does not mean we should not send
a body. Broken by HSTS enhancement.
There's a (small) possibility that the HSTS enhancement is now broken.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Mon May 25 10:59:16 2020
src/sbbs3 websrvr.c 1.716 1.717
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
websrvr.c
Log Message:
Fix transmission of files >= 2GB in size on systems that support large file offsets
(64-bit off_t), e.g. 64-bit Linux. Issue reported by plt via irc.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Mon May 25 14:38:55 2020
src/sbbs3 websrvr.c 1.717 1.718
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23357
Modified Files:
websrvr.c
Log Message:
Improve send-file performance on Windows (over Gb Ethernet LAN) from about 1 MBytes/second to 25+ MBytes/second by increasing the size of the ringbuffer (from 20 -> 256 KBytes) and the size of the file-read buffer in sock_sendfile().
Also log the through-put (in cps) when a file is sent.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Mon May 25 15:05:57 2020
src/sbbs3 websrvr.c 1.718 1.719
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
websrvr.c
Log Message:
Address gcc warning: format '%d' expects argument of type 'int', but arg
has type 'long int'
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sat Aug 8 08:04:58 2020
src/sbbs3 websrvr.c 1.719 1.720
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17800
Modified Files:
websrvr.c
Log Message:
The problem: the sysop (me) is not notified of critical errors (e.g. synchro.net zone file problems) in a timely manner.
Part of the solution: notify a configured user (e.g. user #1) via short-message/telegram and email/netmail logged-errors when messages of a configured severity (e.g. "Critical") are logged.
The second part of the solution (coming next) will be allowing timed events to log a message of a configurable severity logged when the event fails (returns a non-zero error level to sbbs).
I'm saving the error-notification-user-number and log-severity as part of the node.cnf file because:
- that's where the validation user number is already set
- I can conceive of a large system were certain node ranges (different instances of sbbs) might want different operators to be notified of logged-errors
This also means I eliminated all the legacy com port/modem stuff from the end of the node.cnf file. None of that is used in sbbs v3.
Also included in this commit are improvements around logging:
- reduce the severity of UDP recvfrom failures in services
- a more detailed log message when the mail server successfully delivers an email (via SMTP) - easier to answer the question: was that email you/they sent delivered successfully?
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to sbbs/master on Mon Oct 12 07:31:22 2020
https://gitlab.synchro.net/sbbs/sbbs/-/commit/c9db48cec8efd56f8291443d
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix requests to the webserver using IPv6 address
http://[1234:1234::] requests. The host portion contains ":" after split_port_part(), resulting in a 400 error.
Renaming is_legal_hostname() to is_legal_host(), since requests to webservers are to
"hosts" not "hostnames".
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to sbbs/master on Mon Oct 12 07:31:22 2020
-
From
Rob Swindell@VERT to
Git commit to sbbs/master on Fri Oct 16 16:53:45 2020
https://gitlab.synchro.net/sbbs/sbbs/-/commit/37a23fea45bbdb3589e7d909
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix heap corruption that could occur when HSTS feature is enabled
At least on Windows, when realloc() is used to allocate a new buffer,
guess what's in that buffer initially? undefined values. So you can't
strcat() onto the end of that! Ouch. This was a fun one to track down.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to sbbs/master on Wed Nov 4 18:28:33 2020
-
From
Stephen Hurd@VERT to
Git commit to sbbs/master on Mon Nov 16 18:25:24 2020
-
From
Rob Swindell@VERT to
Git commit to sbbs/master on Mon Nov 16 18:39:04 2020
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Wed Feb 17 05:55:55 2021
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Wed Feb 17 05:59:17 2021
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Fri Feb 19 17:31:58 2021
https://gitlab.synchro.net/main/sbbs/-/commit/5d3de1eea3288155bc7a630e
Modified Files:
src/sbbs3/websrvr.c
Log Message:
For the cases we'll send a Content-Length of zero, do not send content.
Should fix #223
Introduced in d56ba01f which likely fixed some stuff on the wiki.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Fri Feb 19 18:03:13 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Fri Mar 19 17:25:53 2021
https://gitlab.synchro.net/main/sbbs/-/commit/b881935a0f28b65f66d6218c
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Track the active client "highwater mark" (highest number of concurrent clients)
Could be useful for knowing if you need to increase MaxClients for typical usage.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Mon Mar 22 18:37:38 2021
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Tue Mar 30 17:12:56 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Apr 4 09:15:46 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Apr 4 09:29:04 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Fri Jun 4 20:42:05 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Fri Jun 4 20:42:05 2021
https://gitlab.synchro.net/main/sbbs/-/commit/a487e0c681d380e01a76deeb
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Don't allow colons in web-requested path names on Windows
This fixes issue #269 (NTFS Alternate Data Stream vulnerability) and other potential pathname issues on Windows involving colons.
There are other illegal filename characters on Windows (e.g. <>|"?*), but filenames with these characters aren't expected to pass the later stat() test, so should fail with a 404 error.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Thu Jul 1 09:41:24 2021
https://gitlab.synchro.net/main/sbbs/-/commit/f38adc13f4b5169a0d59cbce
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix NULL pointer dereference in read_post_data()
What took down cvs/sbbs yesterday:
Program terminated with signal SIGSEGV, Segmentation fault.
6203 session->req.post_data[session->req.post_len]=0; [Current thread is 1 (Thread 0x7f2b989ff700 (LWP 17031))]
(gdb) print post_len
No symbol "post_len" in current context.
(gdb) print session->req.post_len
$1 = 0
(gdb) print session->req.post_data
$2 = 0x0
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sat Jan 15 13:09:53 2022
https://gitlab.synchro.net/main/sbbs/-/commit/f2858ee600525704d27011e0
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Add support for web request path aliases (defined in web_alias.ini)
Similar to the ctrl/ftpalias.cfg file, the new ctrl/web_alias.ini file (optional) can be used to map a portion (the first portion, only) of a web request path to a different physical or virtual path. For example, I'm using it to map:
/Synchronet/ = /files/main/sbbs/
for filebase access to my main->sbbs directory of Vertrauen's filebase using a /Synchronet/* web request (i.e. for slightly prettier or shorter custom URLs, if desired).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Jan 16 17:23:06 2022
https://gitlab.synchro.net/main/sbbs/-/commit/005633b1fffb7b6df70cb13b
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Log requests that resolve outside of the web root as hack attempts
"Request for x is outside of the web root" was already logged (with a "NOTICE" log level), but would not sound the hack attempt alarm (on Windows) or log to the hack.log. Now it does.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Ragnarok@VERT/DOCKSUD to
Rob Swindell on Mon Jan 17 06:57:21 2022
El 15/1/22 a las 23:09, Rob Swindell escribi¢:
https://gitlab.synchro.net/main/sbbs/-/commit/f2858ee600525704d27011e0 Modified Files:
src/sbbs3/websrvr.c
Log Message:
Add support for web request path aliases (defined in web_alias.ini)
Similar to the ctrl/ftpalias.cfg file, the new ctrl/web_alias.ini file (optional) can be used to map a portion (the first portion, only) of a web request path to a different physical or virtual path. For example, I'm using it to map:
/Synchronet/ = /files/main/sbbs/
for filebase access to my main->sbbs directory of Vertrauen's filebase using a /Synchronet/* web request (i.e. for slightly prettier or shorter custom URLs, if desired).
---
¨ Synchronet ¨ Vertrauen ¨ Home of Synchronet ¨ [vert/cvs/bbs].synchro.net
alias portion (webrequest) can support multiple levels? like:
/ftp/main/ansis = /sbbs/data/main/ansis
/ftp/other/upload = /home/pepe/uploads
??
---
þ Synchronet þ Dock Sud BBS TLD 24 HS - bbs.docksud.com.ar
-
From
Digital Man@VERT to
Ragnarok on Mon Jan 17 08:05:44 2022
Re: Re: src/sbbs3/websrvr.c
By: Ragnarok to Rob Swindell on Mon Jan 17 2022 11:57 am
alias portion (webrequest) can support multiple levels? like:
/ftp/main/ansis = /sbbs/data/main/ansis
/ftp/other/upload = /home/pepe/uploads
Yes. But they likely should end in a '/' too.
--
digital man (rob)
This Is Spinal Tap quote #25:
Viv Savage: Have... a good... time... all the time. That's my philosophy. Norco, CA WX: 58.0øF, 80.0% humidity, 3 mph NW wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Jan 30 09:35:53 2022
https://gitlab.synchro.net/main/sbbs/-/commit/d8c099dbc962727df2723650
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix HTTP-requests for files >= 2GB in size
An int is 32-bits on all supported platforms, so this has always been broken. The actual file size/request-length sent would depend on fun 2's complement math (a 32GB file was being truncated to 433MB).
Also fixed some wrong uses of PRIuOFF: off_t is a signed integer, so technically the maximum file size you can request now is 2^63 bytes, which is "big enough".
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Mon Feb 28 17:33:31 2022
https://gitlab.synchro.net/main/sbbs/-/commit/c0f42027dded92626251d686
Modified Files:
src/sbbs3/websrvr.c
Log Message:
I don't know what I was smoking when I did this, but it's fixed now.
Weird early failure return on TLS sends. Most noticible on local
(ie: fast) connections, but clearly stupid all around when you
look at the code.
Fixed, but some day, I should go back and look how we eneded up in
this mess.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Mar 20 12:26:47 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Mon Apr 4 15:54:27 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sat Jun 4 16:36:14 2022
https://gitlab.synchro.net/main/sbbs/-/commit/a82559e327b74c4513751593
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Use safe string formatting to squelch warnings
Attempt to address 2 GCC version 11.2.0 2 warnings reported by Nelgin
`%s' directive writing up to 3 bytes into a region of size between 1 and 4097
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Mon Jun 6 11:23:48 2022
https://gitlab.synchro.net/main/sbbs/-/commit/2e67162225de28219d747ed1
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Perform a JS garbage collection for each new request in a reused session
A reused HTTP session would never (apparently) perform garbage collection.
The evidence of this was the collection of concurrent user.dat file opens
that would never close until the HTTP sessions were closed. Hundreds or
even thousands of open user.dat's have been seen. After this change,
active web server (webv4 UI) users have not caused these spikes in open user.dat files, at least in my testing.
If no garbage collection was being performed, then likely a lot of JS
heap was being needlessly wasted, which could eventually result in a JS
"out of memory" error. But that's just a theory.
Investigation is needed into why the js_CommonOperationCallback()'s calls to JS_MaybeGC() were not sufficient to actually perform garbage collection
in this case.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Wed Aug 3 14:10:22 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Tue Aug 9 15:38:25 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Aug 21 14:35:34 2022
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Fri Jan 6 14:21:41 2023
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Mon Jan 30 17:13:57 2023
https://gitlab.synchro.net/main/sbbs/-/commit/94f85d5f1c8d8792975b5b03
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix MQTT-published action/login message for web server users
e.g. 20230130T171211-480 0 <unknown user> 76.89.231.66 <no name>
the user number name actually *are* known at this stage
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Debian Linux)@VERT to
Git commit to main/sbbs/master on Sat Feb 4 21:30:51 2023
https://gitlab.synchro.net/main/sbbs/-/commit/fe30acd5338cf267c284f0c0
Modified Files:
src/sbbs3/websrvr.c
Log Message:
More details in "Failure to send header/request to FastCGI socket" log msg
Elevate the log level back to ERROR (from WARNING), as this is not an expected condition and the sysop (me) should be alerted right away. This had previously be lowered (along with some other log messages) from ERROR to WARNING.
When php-fpm is updated (on Debian, anyway), e.g. from 8.1 to 8.2, a new etc/php configuration (pool.d) directory was used which set me back to a default www.conf file that uses Unix domain sockets instead of TCP sockets.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Debian Linux)@VERT to
Git commit to main/sbbs/master on Sat Feb 4 23:23:26 2023
https://gitlab.synchro.net/main/sbbs/-/commit/38b9bc8a15b819c87235b2c6
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Add UNIX domain FastCGI support
Resolves a long-standing todo comment and has made wiki.synchro.net page rendering even faster.
PHP-FPM defaults to creating/listening on UNIX domain sockets.
This resolves gitlab issue #507
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows)@VERT to
Git commit to main/sbbs/master on Sun Feb 5 13:12:23 2023
-
From
Rob Swindell (on Windows)@VERT to
Git commit to main/sbbs/master on Mon Feb 6 11:57:23 2023
https://gitlab.synchro.net/main/sbbs/-/commit/6049bc00c20620b31d6f2d41
Modified Files:
src/sbbs3/websrvr.c
Log Message:
If the FastCGI address starts with a '/', it's obviously a UNIX domain socket
We don't really need the "unix:" prefix now, but just leave that support in
for backward compatibility.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows)@VERT to
Git commit to main/sbbs/master on Mon Feb 6 12:37:21 2023
https://gitlab.synchro.net/main/sbbs/-/commit/73a821b70820580fcf3bba9a
Modified Files:
src/sbbs3/websrvr.c
Log Message:
If the FastCGI address begins with a '.', treat as UNIX Domain Socket as well
<Deuce> So the [previous] change doesn't work with relative paths?
So... support relative UDS paths in this manner (without the "unix:" prefix)
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Debian Linux)@VERT to
Git commit to main/sbbs/master on Mon Mar 13 19:41:29 2023
-
From
Rob Swindell (on ChromeOS)@VERT to
Git commit to main/sbbs/master on Sun Mar 26 19:58:09 2023
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Tue Nov 21 20:45:25 2023
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Wed Nov 22 23:00:36 2023
https://gitlab.synchro.net/main/sbbs/-/commit/5546278f0146522c886cca18
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Open SBBS_SSJS.*.html response file(s) only when actually writing data
The first write to a the temporary SBBS_SSJS.*.html file will open the file. This should reduce the number of 0-byte files left laying around in the the temp directory, which shouldn't be happening in the first place.
Also:
Fixed bug noticed in temp file clean up loop: POST data files would *also*
be retained when the DEBUG_SSJS option flag is set.
Also:
Replace some unsafe string operations with safe equivalents.
Happy Thanksgiving Nelgin!
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Thu Nov 23 17:49:22 2023
https://gitlab.synchro.net/main/sbbs/-/commit/274efc589d79d20711f04da2
Modified Files:
src/sbbs3/websrvr.c
Log Message:
A little clean-up around FILE* opening/closing, error handling
"HTTP Logging" replaced in log messages with "Web Server access-logging".
Using new FCLOSE_OPEN_FILE macro to close and NULify open FILE*'s.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Sat Nov 25 20:27:48 2023
https://gitlab.synchro.net/main/sbbs/-/commit/786add2421406f8f9ed9e113
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Replace IPv6 colons in access-log filenames with exclaimation marks on Windows
Colons are not legal filename characters on Windows and when virtual hosts are enabled, the IPv6 address of the server may be used in the access-log filename so we need to clean that up or errors opening/creating the access-log files occur.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Sun Dec 17 17:53:23 2023
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Mon Dec 18 23:58:19 2023
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Tue Dec 19 20:20:18 2023
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Thu Jan 4 19:17:35 2024
https://gitlab.synchro.net/main/sbbs/-/commit/850a6595d70e78025c5a8f29
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Don't pass a TLS session ID of 0 js_CreateCommonObjects() for non-TLS sessions
The proper sentinel value here for "no TLS session" is -1, not 0.
This, at minimum, was causing a lot of extraneous calls to destroy_session() (from js_socket.c's do_js_close()) with an invalid (hopefully, not
otherwise used) cryptlib session ID of 0.
Nothing checks or logs the return value of destroy_session(), but I'd expect
it to be failing ... a lot.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Sun Jan 7 19:19:40 2024
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Mon Jan 15 21:14:44 2024
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Wed Feb 7 14:58:35 2024
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Fri Feb 9 09:07:36 2024
https://gitlab.synchro.net/main/sbbs/-/commit/5bd8253c7c482272b9a4ea1f
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Temporary workaround for TLS issue.
It appears that if the timing is "just wrong", a large POST can
cause TLS to fail. This has shown up as an inability to edit
pages in the wiki.
This is not a fix however, but simple a workaround until this is
root-caused.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Tue Feb 13 23:38:15 2024
https://gitlab.synchro.net/main/sbbs/-/commit/6326f6d0d33019f5af7b31fb
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Set javascript callback "terminated" flag to true when recycling
(or terminating) the server.
This will allow background JS threads to terminate when recycling, so the server doesn't just hang indefinitelyi when recycling.
Add more logging in cleanup() when waiting for children threads to terminate.
Also, eliminate the global 'terminate' variable, answering the question:
Can this be changed to a if(ws_set!=NULL) check instead?
Yes, yes it can.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on ChromeOS)@VERT to
Git commit to main/sbbs/master on Wed Feb 14 00:28:02 2024
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Thu Feb 15 22:55:31 2024
https://gitlab.synchro.net/main/sbbs/-/commit/8d7d9eb22fbabde369e6ab31
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Lower severity of "Response file path is NULL" log msg from CRIT to WARNING
This is not a completely unexpected thing to happen during ungraceful termination
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Wed Feb 21 07:47:10 2024
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Mon Mar 18 21:22:06 2024
https://gitlab.synchro.net/main/sbbs/-/commit/e9778331b2584afc731f45bc
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Fix a bunch of false "File sent" logs (and uploader-notifications)
Web browsers tend start a download and then immediately close the socket
(so now send_failed will be true), while on a secondary socket, do a range download of the same file.
So log the range requests/completions and don't log successful file sends
when the send was terminated due to a send failure.
We still count very small (e.g. 2 byte) ranges as successful file transfers
and notify the uploader (of a partial download), so we should fix those
issues still. But at least now, there's a whole lot less "noise" created
from HTTP[S} file downloads via browser.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Sat Mar 23 17:11:55 2024
https://gitlab.synchro.net/main/sbbs/-/commit/3711e03ad615c3183aa401b4
Modified Files:
src/sbbs3/websrvr.c
Log Message:
Use volatile keyword to (maybe) fix CID 488122: Data race condition
Ideally, I'd use atomic_bool instead, but we're using an older WinSDK for Win7 compatibility and so... can't.
Perhaps an xpdev 'protected_bool_t' should be created.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Sun Mar 24 15:46:02 2024