-
src/sbbs3/js_file.c
From
rswindell@VERT to
CVS commit on Mon Apr 2 11:37:00 2018
src/sbbs3 js_file.c 1.170 1.171
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11679
Modified Files:
js_file.c
Log Message:
The 'e' (exclusive-open) mode flag (introduced in v3.12) never worked. It was simply ignored when converted to the underlying open mode passed to sopen(). Deprecate this flag and log a warning when it is detected as used in a script: Deprecated open flag used: 'e'
Added 'x' (exclsuive-open) mode flag which:
1. was tested to work as intended
2. is consistent with the C11 standard for fopen() mode flags
3. won't cause existing scripts to suddenly break
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Mon Apr 2 12:22:00 2018
src/sbbs3 js_file.c 1.171 1.172
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14685
Modified Files:
js_file.c
Log Message:
Updated JS warning when using old/deprecated file open mode 'e':
"Deprecated file open mode: 'e'"
If this is your script generating this warning, either remove the 'e' from
the File open() mode string (it had no effect anyway) or change to 'x' to
get the real/working exclusive-open functionality (added in v3.17).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Tue Aug 28 10:47:00 2018
src/sbbs3 js_file.c 1.172 1.173
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16344
Modified Files:
js_file.c
Log Message:
New File properties to change .ini file style attributes:
- ini_key_len
- ini_key_prefix
- ini_section_separator
- ini_value_separator
- ini_bit_separator
- ini_literal_separator
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Tue Aug 28 11:47:00 2018
src/sbbs3 js_file.c 1.173 1.174
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3
Modified Files:
js_file.c
Log Message:
Fix a number of problems in the previous commit (ini styles).
Also, the File() constructor will now properly complain if no filename
is passed.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Tue Jan 8 21:54:00 2019
src/sbbs3 js_file.c 1.174 1.175
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20725
Modified Files:
js_file.c
Log Message:
Updated JSDOCS descriptions of File.ini methods.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed Jan 9 22:51:00 2019
src/sbbs3 js_file.c 1.175 1.176
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/jsdocs/src/sbbs3
Modified Files:
js_file.c
Log Message:
Fix JSDOCS_BUILD issue introduced in previous commit.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sat Mar 23 21:55:00 2019
src/sbbs3 js_file.c 1.177 1.178
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24534
Modified Files:
js_file.c
Log Message:
Updated JS doc strings.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sun Jul 14 16:35:45 2019
src/sbbs3 js_file.c 1.180 1.181
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2257
Modified Files:
js_file.c
Log Message:
Fix long-standing issue with File.attributes on Windows: the value *read*
was based on _finddata_t.attrib value while the value *written* was based on struct stat.st_mode, and totally incompatible.
Just use the stat/chmod compatible value for both read and write (for all OSes). If you need the old Windows-centric attribute values (e.g. to determine "hidden" or "archive" attributes), use file_attrib() instead.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed Jul 17 16:14:48 2019
src/sbbs3 js_file.c 1.181 1.182
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18853
Modified Files:
js_file.c
Log Message:
Bug in JSDOCS: File.iniSetAllObjects returns a Boolean, not an Array.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Thu Aug 15 07:34:04 2019
src/sbbs3 js_file.c 1.182 1.183
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6042
Modified Files:
js_file.c
Log Message:
Fix "off-by-one" error in File.readln() and readAll() with regards to the 'maxlen' argument. E.g. passing 10 would result in a maximum read string length of 9 characters.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Tue Aug 20 15:28:01 2019
src/sbbs3 js_file.c 1.183 1.184
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21798
Modified Files:
js_file.c
Log Message:
Fix potential double-close() call in File.open() method implementation:
if fdopen() failed, we'd close the file descriptor but leave it dangling with
a >= 0 value and then call close() again on it later in the function.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed Aug 21 07:32:34 2019
src/sbbs3 js_file.c 1.184 1.185
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20572
Modified Files:
js_file.c
Log Message:
Report a JS warning, with details, when fdopen() fails.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Tue Aug 27 05:47:58 2019
src/sbbs3 js_file.c 1.185 1.186
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11820
Modified Files:
js_file.c
Log Message:
Actually honour File.network_byte_order.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed Sep 18 19:03:53 2019
src/sbbs3 js_file.c 1.186 1.187
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17577
Modified Files:
js_file.c
Log Message:
Address some debug-log output issues with the File object:
"4294967295 File closed"
"0000 File closed: /path/to/file"
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Wed Sep 18 19:49:02 2019
src/sbbs3 js_file.c 1.187 1.188
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27489
Modified Files:
js_file.c
Log Message:
Don't leak FILE streams for calls to js_CreateFileObject(), setting external
to TRUE meant the FILE* (created with fdopen) would never be closed. So we now duplicate the file descriptor and get rid of the external flag, always closing Files (FILE streams) upon File object finalize.
This fixes the resource leak leading to the eventual "Error 24 opening ..." in the ircd.js when loaded via jsexec, on Windows. This error happened after
169 calls to load(true,...), because each background load creates 3 Files
(for stdin/out/err) and those FILE streams were never closed/freed, and
169 * 3 = 507, plus a few open files = 512, the maximum number of open file streams in the Microsoft CRTL apparently. Thanks to Deuce for recognizing these numbers as "magic" and pointing to the likely cause.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
deuce@VERT to
CVS commit on Wed Sep 18 19:54:49 2019
src/sbbs3 js_file.c 1.188 1.189
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29285
Modified Files:
js_file.c
Log Message:
Even more leak paranoia...
If dup() fails, return NULL
If callog() fails, fclose() the new FILE*
No functional change (hopefully).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sun Apr 5 18:21:02 2020
src/sbbs3 js_file.c 1.190 1.191
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9740
Modified Files:
js_file.c
Log Message:
Don't try to convert null or undefined arguments to integers.
Moved some dbprintf() lines around a bit.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Mon Apr 6 14:31:21 2020
src/sbbs3 js_file.c 1.191 1.192
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15683
Modified Files:
js_file.c
Log Message:
Special handling of negative numbers in the writeBin() method implementation. JS numbers are double-precision floating points (doubles) and doubles cannot
be converted to unsigned integers uniformly across all architectures (e.g. specifically on ARM, negative numbers would mostly get converted to 0U).
For details, see
https://www.embeddeduse.com/2013/08/25/casting-a-negative-float-to-an-unsigned-int/
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sat Apr 11 15:25:31 2020
src/sbbs3 js_file.c 1.192 1.193
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18066
Modified Files:
js_file.c
Log Message:
Added optional "lowercase" argument to File.iniGetObject() and iniGetAllObjects() to sort of "normalize" the key names into easily-useable (and consistent) JavaScript property names.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sat Apr 11 20:27:25 2020
src/sbbs3 js_file.c 1.193 1.194
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv428
Modified Files:
js_file.c
Log Message:
Restore the previous behavior of File.iniGetObject(null), even though not documented (it says if the section is *undefined*, the root section is read)
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Sat Apr 11 20:58:01 2020
src/sbbs3 js_file.c 1.194 1.195
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4839
Modified Files:
js_file.c
Log Message:
Document the iniGetObject(null) behavior.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
rswindell@VERT to
CVS commit on Thu Apr 16 18:37:14 2020
src/sbbs3 js_file.c 1.195 1.196
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv894
Modified Files:
js_file.c
Log Message:
Update to File.iniGetAllObjects(): read the .ini file all in one go using iniReadFile():
- enables the use of the !include directive in the read .in file
- reduces rewinds/re-reads of the .ini file, speeding up the total operation
I also removed the old crash dump comments from here.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to sbbs/master on Fri Nov 13 08:55:10 2020
https://gitlab.synchro.net/sbbs/sbbs/-/commit/1af02470226933aa5f04a0f7
Modified Files:
src/sbbs3/js_file.c
Log Message:
JS File.iniGetObject() and .iniGetAllObjects() now support blank strings
If an .ini file is read by either the iniGetObject() or iniGetAllObjects() methods and contains a key with a blank value, that property would be created with an "undefined" value.
Both the iniGetObject() and iniGetAllObjects() methods now accept an additional Boolean argument (which defaults to false), to specify that "blanks" are acceptable. When the "blanks" argument is true, then keys with empty values in the .ini file are created as properties with empty string values (length of 0).
This is going to be useful for modopts.js to read potentially-blank strings from modopts.ini and differentiate between a blank string key and a missing key.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Jan 3 09:16:24 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Jan 24 08:52:29 2021
https://gitlab.synchro.net/main/sbbs/-/commit/8fdbb1692b8ad6c1959f8f3e
Modified Files:
src/sbbs3/js_file.c
Log Message:
More support for !include in .ini files
Some (important) File methods did not support .ini files that used the !include directive because they were using the xpdev iniRead* API (which performs no "pre-processing") instead of xpdev iniGet*.
Impacted methods:
- iniGetValue()
- iniGetKeys()
- iniGetObject()
The other existing ini* methods already worked fine with nested (!include'd) .ini files. It's possible there's a slight performance penalty with the new implementation since the entire .ini file is always read for each operation and previously it was possible that only a few "lines" were read to find the key(s) of interest. However, since .ini files are not typically huge and the iniRead/file-stream method likely read large (e.g. 8-32K) blocks anyway (which is usually the entire .ini file) - I don't actually suspect any observable impact to performance.
This change was needed for the new ctrl/modopts.d support.
Added new method useful for debugging nested .ini files:
- iniReadAll()
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Deuce@VERT to
Git commit to main/sbbs/master on Mon Jan 25 12:05:31 2021
-
From
Deuce@VERT to
Git commit to main/sbbs/master on Tue Jan 26 05:19:30 2021
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Thu Mar 4 12:05:54 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Apr 4 09:38:22 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Apr 4 11:13:57 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Thu Apr 22 16:22:12 2021
https://gitlab.synchro.net/main/sbbs/-/commit/8f79438d2ca277e2c8a25a24
Modified Files:
src/sbbs3/js_file.c
Log Message:
Use JS_ValueToECMAUint32 for File position, date, and length properties
This resolves errors when setting these properties to values > 2147483647 example:
!JavaScript /sbbs/exec/load/sauce_lib.js line 69: Error: can't convert 2430770157 to an integer
That means you can now seek around (set position) within files > 2GB, truncate or extend a file > 2GB, or set a file's date to > Jan-19-2038.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Thu Dec 30 09:31:31 2021
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sat Jan 1 18:58:45 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sun Jan 2 10:58:28 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Tue Mar 1 17:43:08 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Wed Mar 2 05:07:45 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Sat Jun 25 11:20:45 2022
-
From
Rob Swindell@VERT to
Git commit to main/sbbs/master on Mon Jan 16 20:41:25 2023
-
From
Rob Swindell (in GitKraken)@VERT to
Git commit to main/sbbs/master on Tue Mar 14 21:25:14 2023
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Sun Mar 24 15:41:49 2024
-
From
Rob Swindell (on Debian Linux)@VERT to
Git commit to main/sbbs/master on Sat May 25 14:28:35 2024
https://gitlab.synchro.net/main/sbbs/-/commit/7dcfa20fe2f1ce9eb52a3ba1
Modified Files:
src/sbbs3/js_file.c
Log Message:
Don't convert/store small integers to doubles when reading/writing .ini files
Fix issue #760
UINT_TO_JSVAL automatically handles the storage as the necsesary underlying type in the JS engine.
Values > 0x7fffffff (2147483647) will still be stored (and re-written) as doubles and could be problematic.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Debian Linux)@VERT to
Git commit to main/sbbs/master on Fri Sep 13 20:08:11 2024
https://gitlab.synchro.net/main/sbbs/-/commit/105627890fa49ca6a6198408
Modified Files:
src/sbbs3/js_file.c
Log Message:
Eliminte weird gcc (12.2) warning in release build (only)
Increasing size of mode[] element by 2 bytes eliminated these GCC warnings
that seem like false-positives to me:
sbbs.h:194:48: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
194 | (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
js_file.c:225:25: note: in expansion of macro `JSSTRING_TO_STRBUF'
225 | JSSTRING_TO_STRBUF(cx, str, p->mode, sizeof(p->mode), NULL);
| ^~~~~~~~~~~~~~~~~~
js_file.c:42:17: note: at offset 5 into destination object `mode' of size 5
42 | char mode[5];
| ^~~~
Similar use of JSSTRING_TO_STRBUF in other files (js_console.cpp, js_archive.c) (with larger target buffers) does not trigger the same warnings.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
-
From
Rob Swindell (on Windows 11)@VERT to
Git commit to main/sbbs/master on Sat Sep 21 13:08:41 2024
-
From
Deuc¿@VERT to
Git commit to main/sbbs/master on Tue Oct 1 00:11:39 2024