exec sbbslist.js 1.37 1.38
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv800

Modified Files:
sbbslist.js
Log Message:
Allow up to 20 networks per entry, but only export 10 (the old SBL limit)
in the legacy section of msgbase-exported entries.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.38 1.39
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv7368

Modified Files:
sbbslist.js
Log Message:
Cosmetic improvements to "browse" mode, mainly around editing a BBS entry.
Also clear the screen and display "Returning to <bbs name>" when exiting.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.39 1.40
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv24685

Modified Files:
sbbslist.js
Log Message:
Improvements to the verify_services() method (used only on Vertrauen, likely) and the "imsglist" command (ditto) - better dupe detection.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.40 1.41
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv11349

Modified Files:
sbbslist.js
Log Message:
When displaying additional terminal services, include the description if the protocol is repeated (e.g. Telnet).
When adding/inserting in arrays of items, break the loop if they enter an
empty string. Cancel the add item if the first field is blank.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.41 1.42
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv27731

Modified Files:
sbbslist.js
Log Message:
If you "sbbslist update" but the BBS isn't listed, don't return an error
(-1), since new installs won't yet be listed in their own database (yet).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.42 1.43
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv14074

Modified Files:
sbbslist.js
Log Message:
Don't crash when the 'E'dit and 'R'emove commands are used with an empty
list.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.43 1.44
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv9297

Modified Files:
sbbslist.js
Log Message:
Moved list of common_bbs_services from exec/sbbslist.js to load/sbbslist_lib.js Removed TCP/IP services not supported by BBS clients (e.g. SyncTERM) from the list (e.g. ftp, nntp, smtp, binkp, irc) and added "modem".



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.44 1.45
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32173

Modified Files:
sbbslist.js
Log Message:
Don't import deleted sbl.dab entries (the first character of the BBS's
name is a 0).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.45 1.46
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv3527

Modified Files:
sbbslist.js
Log Message:
Added support for exporting and importing "SBL-Remove" messages to remotely remove a BBS entry (e.g. your own) from remote databases. You can remove
any entry (as before) with "jsexec sbbslist remove=<name>", add the '-remote' option and it'll post an SBL-Remove message to the SYNCDATA sub.
The new "delete" option is the same, but automatically uses your local BBS
name as the name of the entry to be deleted/removed (you still need the -remote option to create an SBL-Remove message).
A confirmation prompt was added.
The "Name:" portion fo the SBL-Remove message body is not actually needed /parsed right now but makes a good sanity check for message subject (BBS name) truncation or manipulation, should that be a problem.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.46 1.47
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv2809

Modified Files:
sbbslist.js
Log Message:
Fix issues with create/editing numeric fields (E.g. service "port") and them being saved as a String value - use the new lib.max_val object to determine numeric fields and limit their values to between 0 and lib.max_val[field].
Also fixed a few parseInt()/octal bugs with date conversions (srsly -still?).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.47 1.48
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv23156

Modified Files:
sbbslist.js
Log Message:
Put more work into insuring that numeric values are created/edited as numbers (not strings).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.48 1.49
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv6398

Modified Files:
sbbslist.js
Log Message:
When adding a new BBS entry, indicate which fields are required first.
Don't allow a blank terminal server address when creating a new entry.
Detect an invalid "first_online" date and reject.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.49 1.50
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13830

Modified Files:
sbbslist.js
Log Message:
Implement the "maint" command handler:
- uses the sbbslist_lib.remove_inactive() method
- uses the (new) max_inactivity (days) value from modopts.ini [sbbslist]
(default: 180 days)
- supports the -v (verbose) option to display details about entries being
removed due to inactivity (if desired)


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.50 1.51
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv21508

Modified Files:
sbbslist.js
Log Message:
Added the -f=<filename.json> and -test options.
Added the 'active' command (show last active date for all entries)
The 'dedupe' command now supports the -v (verbose) option.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.51 1.52
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv300

Modified Files:
sbbslist.js
Log Message:
Lock the database during the "backup" operation.
If the list is not sorted and the (capital) 'S' key is used (in browse mode), sort by the last column instead of the first.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.52 1.53
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv2963

Modified Files:
sbbslist.js
Log Message:
Added support for "lock" and "unlock" commands which will just lock (or unlock) the list database (sbbslist.json) for external processing/modification. When run via jsexec (as intended), jsexec will return 0 if the lock/unlock operation was successful, -1 otherwise. It would be wise to check the errorlevel/return value of jsexec for successful lock before operating on the list file.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.53 1.54
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv27721

Modified Files:
sbbslist.js
Log Message:
Use cached avatar_lib.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.54 1.55
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv3190

Modified Files:
sbbslist.js
Log Message:
More efficient screen updates (i.e., when using the up & down arrows, only move the lightbar on the 2 affected rows, don't redraw the whole list unless going to the next/previous page)


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: nightfox to CVS commit on Thu Nov 14 2019 03:37 pm

exec sbbslist.js 1.54 1.55
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv3190

Modified Files:
sbbslist.js
Log Message:
More efficient screen updates (i.e., when using the up & down arrows, only move the lightbar on the 2 affected rows, don't redraw the whole list unless going to the next/previous page)

Cool that you took the time to do this. I do have some comments however:

1. Introduces a cosmetic bug, as you can see here, the last character of the inversed/selection line remains after moving the selection down one:
https://1drv.ms/u/s!ApZPvWcrEaRQvMcp2zTjElCRGYN_Zw?e=htqMfv

2. This commit includes an arbitray style change, e.g.:
/* Column headings */
to:
// Column headings
If you want to make style changes unrelated to your change, do that in a separate commit.

3. With just a few minor tweaks, this optimization works for PETSCII terminals too (you can easily use SyncTERM in PETSCII, e.g. C128 mode, to test PETSCII).

4. Could we minimize the number of "redraw_whole_list = true" statements by defaulting this value to true rather than false? It seems there's a whole lot of them.

5. You added 2 new function definitions *after* main(), inconsistent with the style used in this source file prior to your touching it. Maybe you just didn't notice, but all other function definitions in this file occurred *prior* to the main() definition.

6. If there are any other bugs with this enhancement, it would be nice to allow a sysop to "opt-out" (e.g. via a modopts.ini setting) rather than having to go back to a previous revision if there's an issue. I have no idea how well the script was tested with your changes.

digital man

Synchronet/BBS Terminology Definition #1:
ANSI = American National Standards Institute
Norco, CA WX: 82.8øF, 32.0% humidity, 0 mph NE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Nov 16 2019 03:15 pm

6. If there are any other bugs with this enhancement, it would be nice to allow a sysop to "opt-out" (e.g. via a modopts.ini setting) rather than having to go back to a previous revision if there's an issue. I have no idea how well the script was tested with your changes.

Here's another cosmetic bug newly introduced with your changes: https://1drv.ms/u/s!ApZPvWcrEaRQvMcqKm0mDhi3M2qlqg?e=TtWm9L

This happens when the user presses the END key to go to the list.

digital man

Synchronet "Real Fact" #15:
SBBSecho was introduced (replacing SBBSFIDO) for Synchronet v2 in 1994.
Norco, CA WX: 82.8øF, 32.0% humidity, 0 mph NE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Nov 16 2019 03:15 pm

Cool that you took the time to do this. I do have some comments however:

1. Introduces a cosmetic bug, as you can see here, the last character of the inversed/selection line remains after moving the selection down one: https://1drv.ms/u/s!ApZPvWcrEaRQvMcp2zTjElCRGYN_Zw?e=htqMfv

Yep, will have to look into that.

2. This commit includes an arbitray style change, e.g.:
/* Column headings */
to:
// Column headings
If you want to make style changes unrelated to your change, do that in a separate commit.

Ah, will make note of that.

3. With just a few minor tweaks, this optimization works for PETSCII terminals too (you can easily use SyncTERM in PETSCII, e.g. C128 mode, to test PETSCII).

I'll have to try that out.

4. Could we minimize the number of "redraw_whole_list = true" statements by defaulting this value to true rather than false? It seems there's a whole lot of them.

Yeah, I'll try to reduce those.

5. You added 2 new function definitions *after* main(), inconsistent with the style used in this source file prior to your touching it. Maybe you just didn't notice, but all other function definitions in this file occurred *prior* to the main() definition.

I'll change that. I didn't really notice and didn't think that would really be an issue.

6. If there are any other bugs with this enhancement, it would be nice to allow a sysop to "opt-out" (e.g. via a modopts.ini setting) rather than having to go back to a previous revision if there's an issue. I have no idea how well the script was tested with your changes.

Seems like for a modopts.ini setting for this, the mod would then have to have 2 versions of the code in it to support toggling it on/off..

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Nov 16 2019 03:20 pm

6. If there are any other bugs with this enhancement, it would be nice
to allow a sysop to "opt-out" (e.g. via a modopts.ini setting) rather
than having to go back to a previous revision if there's an issue. I
have no idea how well the script was tested with your changes.

Here's another cosmetic bug newly introduced with your changes: https://1drv.ms/u/s!ApZPvWcrEaRQvMcqKm0mDhi3M2qlqg?e=TtWm9L

This happens when the user presses the END key to go to the list.

Where's the cosmetic bug? I'm not sure I'm seeing an issue in that screenshot..

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Nov 16 2019 03:15 pm

3. With just a few minor tweaks, this optimization works for PETSCII terminals too (you can easily use SyncTERM in PETSCII, e.g. C128 mode, to test PETSCII).

I tried logging into my BBS using C128 80-column and 40-colum modes, and even the previous version (1.54) didn't look good or behave very well - For instance, when pressing the up & down arrows, I didn't notice any change on the screen, and viewing the selected BBS always viewed the first one on the screen. Should sbbslist.js already works with PETSCII?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

exec sbbslist.js 1.55 1.56
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13101

Modified Files:
sbbslist.js
Log Message:
Addressing a few issues noted in the previous commit: Functions declared after main() are now before main(). Fixes a display glitch when moving the selected BBS using the up/down arrow keys. The redraw_whole_list variable now defaults to true and is set to false when needed, minimizing the number of times it needs to be changed.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sat Nov 16 2019 05:40 pm

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Nov 16 2019 03:20 pm

6. If there are any other bugs with this enhancement, it would be nice
to allow a sysop to "opt-out" (e.g. via a modopts.ini setting) rather
than having to go back to a previous revision if there's an issue. I
have no idea how well the script was tested with your changes.

Here's another cosmetic bug newly introduced with your changes: https://1drv.ms/u/s!ApZPvWcrEaRQvMcqKm0mDhi3M2qlqg?e=TtWm9L

This happens when the user presses the END key to go to the list.

Where's the cosmetic bug? I'm not sure I'm seeing an issue in that screenshot..

See the blank rows after the last entry (Jay's Cafe')? Those aren't there when using rev 1.54 or earlier.

digital man

Synchronet/BBS Terminology Definition #70:
SyncEdit = A defunct 3rd party full-screen editor written for Synchronet
Norco, CA WX: 73.4øF, 24.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sat Nov 16 2019 06:21 pm

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Nov 16 2019 03:15 pm

3. With just a few minor tweaks, this optimization works for PETSCII terminals too (you can easily use SyncTERM in PETSCII, e.g. C128 mode, to test PETSCII).

I tried logging into my BBS using C128 80-column and 40-colum modes, and even the previous version (1.54) didn't look good or behave very well - For instance, when pressing the up & down arrows, I didn't notice any change on the screen, and viewing the selected BBS always viewed the first one on the screen. Should sbbslist.js already works with PETSCII?

Yeah, works great in PETSCII mode. Maybe you're using an old or weird (not the latest and not v1.0) version of SyncTERM?

digital man

Synchronet/BBS Terminology Definition #65:
SMTP = Simple Message Transfer Protocol
Norco, CA WX: 73.4øF, 24.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sat Nov 16 2019 05:40 pm

5. You added 2 new function definitions *after* main(), inconsistent with the style used in this source file prior to your touching it. Maybe you just didn't notice, but all other function definitions in this file occurred *prior* to the main() definition.

I'll change that. I didn't really notice and didn't think that would really be an issue.

It's not so much an "issue" as it is a non-conformant practice. "Best practice" when modifiying someone's else's source code is to follow their example/style, if/when you can. That's all. Ideally, when looking at a source file, it shouldn't be obvious that some parts were written by different developers.

digital man

Synchronet/BBS Terminology Definition #5:
BBS = Bulletin Board System
Norco, CA WX: 74.1øF, 22.0% humidity, 0 mph SSW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.56 1.57
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv9335

Modified Files:
sbbslist.js
Log Message:
Resolution for the issue of there sometimes being a few empty lines between the end of the BBS list and the prompt text - For example, on the last page if the BBS entries don't fill the whole screen.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sat Nov 16 2019 09:39 pm

Yeah, works great in PETSCII mode. Maybe you're using an old or weird (not the latest and not v1.0) version of SyncTERM?

I was using a v1.1b build from June of this year. I tried downloading the latest build, but it looked the same.

Using the 1.54 version of sbbslist.js, this is a screenshot of what I see using the C128 80-column mode - After I ran the SBBS list, I pressed the right arrow. One thing I noticed is that in the word "sYNCHRONET", the 's' starts at the last column in the first row:
http://www.digitaldistortionbbs.com:81/sbbslist-petscii/sl154-p80-rarrow.png

And this is what I see in C128 40-column mode - It looks like it's not wrapping properly, and the 2 header lines don't show up:
http://www.digitaldistortionbbs.com:81/sbbslist-petscii/sl154-p40.png

That's why I was wondering if sbbslist.js was currently working with PETSCII or not.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sun Nov 17 2019 03:16 pm

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sat Nov 16 2019 09:39 pm

Yeah, works great in PETSCII mode. Maybe you're using an old or weird (not the latest and not v1.0) version of SyncTERM?

I was using a v1.1b build from June of this year. I tried downloading the latest build, but it looked the same.

Using the 1.54 version of sbbslist.js, this is a screenshot of what I see using the C128 80-column mode - After I ran the SBBS list, I pressed the right arrow. One thing I noticed is that in the word "sYNCHRONET", the 's' starts at the last column in the first row: http://www.digitaldistortionbbs.com:81/sbbslist-petscii/sl154-p80-rarrow.png

You're not in PETSCII mode. Logon to Vertrauen, port 64 (for 40-column PETSCII) or port 128 (for 80-column PETSCII) to see what you should be seeing in PETSCII mode.

And this is what I see in C128 40-column mode - It looks like it's not wrapping properly, and the 2 header lines don't show up: http://www.digitaldistortionbbs.com:81/sbbslist-petscii/sl154-p40.png

That's why I was wondering if sbbslist.js was currently working with PETSCII or not.

Whatever BBS you're connected to doesn't appear to be setup to accept PETSCII users.

digital man

Synchronet/BBS Terminology Definition #55:
POP3 = Post Office Protocol version 3
Norco, CA WX: 85.0øF, 12.0% humidity, 0 mph S wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sun Nov 17 2019 04:38 pm

Whatever BBS you're connected to doesn't appear to be setup to accept PETSCII users.

That's my BBS. :P What option do I need to enable to accept PETSCII users?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sun Nov 17 2019 06:28 pm

That's my BBS. :P What option do I need to enable to accept PETSCII users?

I see the option now - I see there are options in sbbs.ini for the ports for PETSCII 40-column and 80-column. I tried connecting to my BBS at those ports but I couldn't connect - I'll have to look into that.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sun Nov 17 2019 06:49 pm

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sun Nov 17 2019 06:28 pm

That's my BBS. :P What option do I need to enable to accept PETSCII users?

I see the option now - I see there are options in sbbs.ini for the ports for PETSCII 40-column and 80-column. I tried connecting to my BBS at those ports but I couldn't connect - I'll have to look into that.

I wrote up a how-to:
http://wiki.synchro.net/howto:petscii

Hopefully that helps.

digital man

Synchronet "Real Fact" #104:
Synchronet channel: http://www.youtube.com/channel/UCsQ8iXU5yvrybyoEgo__97A Norco, CA WX: 75.1øF, 18.0% humidity, 0 mph WSW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sun Nov 17 2019 07:03 pm

I wrote up a how-to:
http://wiki.synchro.net/howto:petscii

Hopefully that helps.

Thanks. I figured it out from an example in a newer sbbs.ini, to specify additional addresses & ports to listen to on the telnet server.

For the screen refresh update with sbbslist.js, to get rid of the UI glitch where it was leaving a blue character at the end of the lines, I added these 2 lines to the list_bbs_entry() function:

console_color(color, selected);
console.cleartoeol();

That seems to work okay for an ANSI client, but for PETSCII, I still see a similar weird glitch for the first BBS entry on a page. For example, the following 4 screenshots are for PETSCII using the up & down arrows:

http://www.digitaldistortionbbs.com:81/sbbslist-petscii/1.png http://www.digitaldistortionbbs.com:81/sbbslist-petscii/2.png http://www.digitaldistortionbbs.com:81/sbbslist-petscii/3.png http://www.digitaldistortionbbs.com:81/sbbslist-petscii/4.png

I'm not sure what might be causing the glitch on the first entry, and only for PETSCII..

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Tue Nov 19 2019 07:46 pm

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sun Nov 17 2019 07:03 pm

I wrote up a how-to:
http://wiki.synchro.net/howto:petscii

Hopefully that helps.

Thanks. I figured it out from an example in a newer sbbs.ini, to specify additional addresses & ports to listen to on the telnet server.

For the screen refresh update with sbbslist.js, to get rid of the UI glitch where it was leaving a blue character at the end of the lines, I added these 2 lines to the list_bbs_entry() function:

console_color(color, selected);
console.cleartoeol();

That seems to work okay for an ANSI client, but for PETSCII, I still see a similar weird glitch for the first BBS entry on a page. For example, the following 4 screenshots are for PETSCII using the up & down arrows:

http://www.digitaldistortionbbs.com:81/sbbslist-petscii/1.png http://www.digitaldistortionbbs.com:81/sbbslist-petscii/2.png http://www.digitaldistortionbbs.com:81/sbbslist-petscii/3.png http://www.digitaldistortionbbs.com:81/sbbslist-petscii/4.png

I'm not sure what might be causing the glitch on the first entry, and only for PETSCII..

It's not obvious to me what would cause that. I see that the BBS Location field for that line seems to be displayed one-char to the right too. These problems don't appear in revisions of sbbslist.js before your changes, so it must be something new. <shrug>

There is a difference in how ANSI cleartoeol() and non-ANSI (e.g. PETSCII) cleartoeol() works, but it certainly seems to work in all other use-cases. I use it a lot in Minesweeper as well, no problems in PETSCII mode.

You tried different versions of SyncTERM too?

digital man

This Is Spinal Tap quote #3:
How much more black could this be? and the answer is none. None more black. Norco, CA WX: 61.8øF, 81.0% humidity, 4 mph ESE wind, 0.01 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Tue Nov 19 2019 09:20 pm

I'm not sure what might be causing the glitch on the first entry, and only
for PETSCII..

It's not obvious to me what would cause that. I see that the BBS Location field for that line seems to be displayed one-char to the right too. These problems don't appear in revisions of sbbslist.js before your changes, so it must be something new. <shrug>

It seems to have issues even with the display_bbs_entry() function unchanged. I have a feeling it may have something to do with refreshing individual BBS entry lines (compared to writing a whole screenful of BBS entries), though I'm not sure.

There is a difference in how ANSI cleartoeol() and non-ANSI (e.g. PETSCII) cleartoeol() works, but it certainly seems to work in all other use-cases. I use it a lot in Minesweeper as well, no problems in PETSCII mode.

I've noticed some slight difference in behavior with cleartoeol()..

You tried different versions of SyncTERM too?

I haven't, but I might give that a try.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

exec sbbslist.js 1.57 1.58
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv16161

Modified Files:
sbbslist.js
Log Message:
Improved the optimized screen drawing behavior for PETSCII. There's still a glitch in refreshing the last character on the row when moving the lightbar with the up/down arrow keys, but it's more well-behaved now for PETSCII.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.57 1.58
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv16161

Modified Files:
sbbslist.js
Log Message:
Improved the optimized screen drawing behavior for PETSCII. There's still a glitch in refreshing the last character on the row when moving the lightbar with the up/down arrow keys, but it's more well-behaved now for PETSCII.

if(console.terminal.toUpperCase() === 'PETSCII') var line_screen_len = (strip_ctrl(txt).length - 1) else var line_screen_len = strip_ctrl(txt).length

???

---
þ Synchronet þ AlleyCat! BBS - http://alleycat.synchro.net:81

Re: Re: exec/sbbslist.js
By: Mortifis to nightfox on Wed Nov 20 2019 10:16 pm

if(console.terminal.toUpperCase() === 'PETSCII') var line_screen_len = (strip_ctrl(txt).length - 1) else var line_screen_len = strip_ctrl(txt).length

???

What's your question? I don't see that code in sbbslist.js.. Are you trying to suggest a piece of code, or..?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: nightfox to CVS commit on Wed Nov 20 2019 09:26 am

exec sbbslist.js 1.57 1.58
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv16161

Modified Files:
sbbslist.js
Log Message:
Improved the optimized screen drawing behavior for PETSCII. There's still a glitch in refreshing the last character on the row when moving the lightbar with the up/down arrow keys, but it's more well-behaved now for PETSCII.

Looking at your changes, I have a question:

var txt = format("%-*s%c", lib.max_len.name, bbs.name, selected ? '<' : ' ');
console.print(txt);
var line_screen_len = strip_ctrl(txt).length; // To help clearing to EOL for PETSCII

What control characters or sequences in 'txt' would you expect to be stripping at this point? There shouldn't be any in bbs.name and '<' and ' ' aren't control characters, so I'm confused by this logic. It looks like maybe you copy/pasted this design pattern into a few places and some where it's not applicable.

Also, the correct way to measure the number of columns that would be represented by a printed string (accounting for control characters/sequences) is via console.strlen().

digital man

Synchronet "Real Fact" #24:
1584 Synchronet BBS Software registrations were sold between 1992 and 1996. Norco, CA WX: 59.0øF, 92.0% humidity, 3 mph SE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.58 1.59
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv8067

Modified Files:
sbbslist.js
Log Message:
Replaced strip_ctrl(txt).length to console.strlen(txt) in a few places


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Dec 07 2019 05:26 pm

Looking at your changes, I have a question:

var txt = format("%-*s%c", lib.max_len.name, bbs.name, selected ? '<' : ' '); console.print(txt);
var line_screen_len = strip_ctrl(txt).length; // To help clearing to EOL for PETSCII

What control characters or sequences in 'txt' would you expect to be stripping at this point? There shouldn't be any in bbs.name and '<' and ' ' aren't control characters, so I'm confused by this logic. It looks like maybe you copy/pasted this design pattern into a few places and some where it's not applicable.

Also, the correct way to measure the number of columns that would be represented by a printed string (accounting for control characters/sequences) is via console.strlen().

The intent was to get the length of the string as printed on the screen. I've just committed an update changing those to use console.strlen().

The documentation says console.strlen() returns the length of the string excluding Ctrl-A codes. So it seems it's functionally equivalent to strip_ctrl(txt).length - Is that correct? Or are there other differences?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sat Dec 07 2019 11:07 pm

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Dec 07 2019 05:26 pm

Looking at your changes, I have a question:

var txt = format("%-*s%c", lib.max_len.name, bbs.name, selected ? '<' : ' '); console.print(txt);
var line_screen_len = strip_ctrl(txt).length; // To help clearing to EOL for PETSCII

What control characters or sequences in 'txt' would you expect to be stripping at this point? There shouldn't be any in bbs.name and '<' and ' ' aren't control characters, so I'm confused by this logic. It looks like maybe you copy/pasted this design pattern into a few places and some where it's not applicable.

Also, the correct way to measure the number of columns that would be represented by a printed string (accounting for control characters/sequences) is via console.strlen().

The intent was to get the length of the string as printed on the screen.

I guessed that was the intent, but how would txt.length be any different than strip_ctrl(txt).length in the code I pasted above?

I've just committed an update changing those to use console.strlen().

The documentation says console.strlen() returns the length of the string excluding Ctrl-A codes. So it seems it's functionally equivalent to strip_ctrl(txt).length - Is that correct? Or are there other differences?

strip_ctrl() actually modifies a string while console.strlen() calculates the displayed-length without modifying the string. There are other minor differences (e.g. Ctrl-AZ handling), but that's the main one.

digital man

This Is Spinal Tap quote #30:
Big bottom, big bottom / Talk about mud flaps, my girl's got 'em!
Norco, CA WX: 56.8øF, 98.0% humidity, 0 mph SE wind, 0.01 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sun Dec 08 2019 12:02 am

The intent was to get the length of the string as printed on the
screen.

I guessed that was the intent, but how would txt.length be any different than strip_ctrl(txt).length in the code I pasted above?

I suppose it wouldn't; I've had a habit of doing that in some other JS code where the text would have Ctrl-A codes, as is often the case in other code I've written where the text has color codes.

The documentation says console.strlen() returns the length of the
string excluding Ctrl-A codes. So it seems it's functionally
equivalent to strip_ctrl(txt).length - Is that correct? Or are there
other differences?

strip_ctrl() actually modifies a string while console.strlen() calculates the displayed-length without modifying the string. There are other minor differences (e.g. Ctrl-AZ handling), but that's the main one.

I suppose console.strlen() would be more efficient.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: nightfox to CVS commit on Wed Nov 20 2019 09:26 am

exec sbbslist.js 1.57 1.58
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv16161

Modified Files:
sbbslist.js
Log Message:
Improved the optimized screen drawing behavior for PETSCII. There's still a glitch in refreshing the last character on the row when moving the lightbar with the up/down arrow keys, but it's more well-behaved now for PETSCII.

There is a PETSCII issue where a console.cleartoeol() cannot actually clear the last character of the line because:
1. We don't know for sure what line/row the cursor is currently on
2. If we write to the last cell of the last line/row, the terminal will scroll

This isn't a problem with ANSI because there's an actual escape sequence for clear-to-end-of-line which we use when the terminal supports ANSI, but for non-ANSI (including PETSCII), we instead overwrite all the characters in the current row (except the last) with space and then backspace/left-cursor back to the original cursor position.

This is likely the PETSCII issue now observed with your modification.

Now, sbbslist.js is pretty sure it knows the current line/row and could possibly indicate to console.cleartoeol() when it's on the last row, but that would also require a change to the console.cleartoeol() implementation (e.g. to accept an additional parameter or whatever). So... it's probably better to just avoid writing to that last character cell. I'll look into it more when I have some time/motivation. I just wanted to make a note of the difference in behavior of console.cleartoeol() for ANSI vs. non-ANSI.

digital man

Synchronet/BBS Terminology Definition #29:
FSP = FidoNet Standards Proposal
Norco, CA WX: 63.5øF, 62.0% humidity, 3 mph ESE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to nightfox on Tue Dec 10 2019 12:22 pm

Improved the optimized screen drawing behavior for PETSCII. There's
still a glitch in refreshing the last character on the row when moving
the lightbar with the up/down arrow keys, but it's more well-behaved
now for PETSCII.

There is a PETSCII issue where a console.cleartoeol() cannot actually clear the last character of the line because: 1. We don't know for sure what line/row the cursor is currently on 2. If we write to the last cell of the last line/row, the terminal will scroll

This isn't a problem with ANSI because there's an actual escape sequence for clear-to-end-of-line which we use when the terminal supports ANSI, but for non-ANSI (including PETSCII), we instead overwrite all the characters in the current row (except the last) with space and then backspace/left-cursor back to the original cursor position.

This is likely the PETSCII issue now observed with your modification.

Now, sbbslist.js is pretty sure it knows the current line/row and could possibly indicate to console.cleartoeol() when it's on the last row, but that would also require a change to the console.cleartoeol() implementation (e.g. to accept an additional parameter or whatever). So... it's probably better to just avoid writing to that last character cell. I'll look into it more when I have some time/motivation. I just wanted to make a note of the difference in behavior of console.cleartoeol() for ANSI vs. non-ANSI.

I wasn't sure what to do about this, but if it's a PETSCII issue, perhaps there isn't much to do besides work around it / deal with it?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Tue Dec 10 2019 12:53 pm

So... it's probably better to just avoid writing to that last character cell. I'll look into it more when I have some time/motivation. I just wanted to make a note of the difference in behavior of console.cleartoeol() for ANSI vs. non-ANSI.

I wasn't sure what to do about this, but if it's a PETSCII issue, perhaps there isn't much to do besides work around it / deal with it?

Yeah, nothing to be done right now. It's an everything-but-ANSI issue. Just something to keep in mind when designing a UI. I may end up adding an additional/optional parameter to console.cleartoeol() to allow it to write to the last cell on a line. I'll give it some more thought first.

digital man

This Is Spinal Tap quote #33:
Nigel Tufnel: Well, so what? What's wrong with bein' sexy?
Norco, CA WX: 65.2øF, 63.0% humidity, 0 mph WNW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.59 1.60
Update of /cvsroot/sbbs/exec
In directory cvs:/home/rswindell/sbbs/exec

Modified Files:
sbbslist.js
Log Message:
Fix "ReferenceError: top is not defined" when the "list" command is used.
Bug introduced in rev 1.59 by Nightfox. "jsexec sbbslist list" still has many other JS errors even after this fix. :-(




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.60 1.61
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv8105

Modified Files:
sbbslist.js
Log Message:
Fix for JS errors when running "jsexec sbbs list"


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.61 1.62
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv18279

Modified Files:
sbbslist.js
Log Message:
Eliminate the unnecessary calls to format() in previous commit.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: nightfox to CVS commit on Sun Nov 17 2019 03:18 pm

exec sbbslist.js 1.56 1.57
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv9335

Modified Files:
sbbslist.js
Log Message:
Resolution for the issue of there sometimes being a few empty lines between the end of the BBS list and the prompt text - For example, on the last page if the BBS entries don't fill the whole screen.

Your modifications to the sbbslist.js still have issues with the 'End' key:

Before your modifications (rev 1.54), hitting the End key would fill the screen with the last scree-full of BBS entires. Since rev 1.55 (and later), hitting 'End' will now put the last BBS entry at the top of the screen and fill the remaining rows with nothingness. :-(

digital man

Synchronet/BBS Terminology Definition #3:
ASCII = American Standard Code for Information Interchange
Norco, CA WX: 53.6øF, 93.0% humidity, 3 mph WNW wind, 0.14 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sun Mar 22 2020 09:31 pm

sbbslist.js

Your modifications to the sbbslist.js still have issues with the 'End' key:

Before your modifications (rev 1.54), hitting the End key would fill the screen with the last scree-full of BBS entires. Since rev 1.55 (and later), hitting 'End' will now put the last BBS entry at the top of the screen and fill the remaining rows with nothingness. :-(

:/ I'll have to take a look at it. Thanks for letting me know.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

exec sbbslist.js 1.62 1.63
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv8354

Modified Files:
sbbslist.js
Log Message:
The 'End' key will now show the last full screen of BBS entries, as before.

One somewhat odd behavior now is that when going up with the up-arrow key, if you go up past the first entry on the last page, it shows only a few entries back instead of a whole page back as I would expect per the new screen refresh optimizations (though it does highlight the correct BBS entry). When going up another page with the up-arrow key, it does refresh the whole page of entries as expected.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: nightfox to CVS commit on Tue Mar 24 2020 10:49 pm

exec sbbslist.js 1.62 1.63
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv8354

Modified Files:
sbbslist.js
Log Message:
The 'End' key will now show the last full screen of BBS entries, as before.

One somewhat odd behavior now is that when going up with the up-arrow key, if you go up past the first entry on the last page, it shows only a few entries back instead of a whole page back as I would expect per the new screen refresh optimizations (though it does highlight the correct BBS entry). When going up another page with the up-arrow key, it does refresh the whole page of entries as expected.

Still no good:
https://1drv.ms/u/s!ApZPvWcrEaRQvNJ_D95Ihb5oSZdXUA?e=DbiXZN

This happens if go to the end and then scroll back up (like you described) and then back down again. It's definitely wonky.

digital man

Synchronet "Real Fact" #24:
1584 Synchronet BBS Software registrations were sold between 1992 and 1996. Norco, CA WX: 54.4øF, 71.0% humidity, 2 mph NNW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to nightfox on Wed Mar 25 2020 06:54 pm

Still no good:
https://1drv.ms/u/s!ApZPvWcrEaRQvNJ_D95Ihb5oSZdXUA?e=DbiXZN

This happens if go to the end and then scroll back up (like you described) and then back down again. It's definitely wonky.

What exactly should I be seeing here? That doesn't look that bad to me. Is it that there are empty lines at the bottom and it doesn't fill the page? How are you expecting it to behave?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Thu Mar 26 2020 02:00 pm

Re: exec/sbbslist.js
By: Digital Man to nightfox on Wed Mar 25 2020 06:54 pm

Still no good: https://1drv.ms/u/s!ApZPvWcrEaRQvNJ_D95Ihb5oSZdXUA?e=DbiXZN

This happens if go to the end and then scroll back up (like you described) and then back down again. It's definitely wonky.

What exactly should I be seeing here? That doesn't look that bad to me. Is it that there are empty lines at the bottom and it doesn't fill the page?

Correct. The "List" prompt is normally on the bottom of the terminal and the listings (if there is at least a screenfull) fill the screen.

How are you expecting it to behave?

The same as it did before you modified it. Specifically, this revision here: http://cvs.synchro.net/cgi-bin/viewcvs.cgi/*checkout*/exec/sbbslist.js?revision=1.54

digital man

Synchronet/BBS Terminology Definition #54:
Phreak = Telephone system hack[er]
Norco, CA WX: 51.5øF, 61.0% humidity, 7 mph NNW wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.63 1.64
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv681

Modified Files:
sbbslist.js
Log Message:
When using navigation keys such as HOME, END, PageUp, PageDown, and the up & down arrow keys, the BBS entries will now fill the whole screen, even when you scroll to the end of the BBS list.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: nightfox to CVS commit on Sat Mar 28 2020 05:03 pm

exec sbbslist.js 1.63 1.64
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv681

Modified Files:
sbbslist.js
Log Message:
When using navigation keys such as HOME, END, PageUp, PageDown, and the up & down arrow keys, the BBS entries will now fill the whole screen, even when you scroll to the end of the BBS list.

Scrolling is still not behaving as it did before you started modifying it. Now, when you arrow up while at the top of the a page-full or arrow down while at the bottom fo a page-full, rather than scroll by one (and leave the selection bar at the top or bottom), the list is scrolled by a full page full (as if page up or page down was struck) and the selection bar moves to the opposite side of the screen (i.e if it was at the top, it moves to the bottom, or vice versa).

digital man

Synchronet/BBS Terminology Definition #37:
IBM = International Business Machines (Corporation)
Norco, CA WX: 63.0øF, 47.0% humidity, 5 mph ESE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Mar 28 2020 05:29 pm

Scrolling is still not behaving as it did before you started modifying it. Now, when you arrow up while at the top of the a page-full or arrow down while at the bottom fo a page-full, rather than scroll by one (and leave the selection bar at the top or bottom), the list is scrolled by a full page full (as if page up or page down was struck) and the selection bar moves to the opposite side of the screen (i.e if it was at the top, it moves to the bottom, or vice versa).

That was intentional, for screen refresh optimizations. Rather than re-draw the whole list every time you scroll one item, I thought it would be more efficient to draw a whole page once, and then when you move up or down, to only re-draw the lightbar for 2 items each time (until you go to the next page). Do you think this behavior is undesirable?

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sat Mar 28 2020 06:56 pm

Re: exec/sbbslist.js
By: Digital Man to nightfox on Sat Mar 28 2020 05:29 pm

Scrolling is still not behaving as it did before you started modifying it. Now, when you arrow up while at the top of the a page-full or arrow down while at the bottom fo a page-full, rather than scroll by one (and leave the selection bar at the top or bottom), the list is scrolled by a full page full (as if page up or page down was struck) and the selection bar moves to the opposite side of the screen (i.e if it was at the top, it moves to the bottom, or vice versa).

That was intentional, for screen refresh optimizations. Rather than re-draw the whole list every time you scroll one item, I thought it would be more efficient to draw a whole page once, and then when you move up or down, to only re-draw the lightbar for 2 items each time (until you go to the next page). Do you think this behavior is undesirable?

It's surprising behavior (to me) for the arrow keys and I don't care for surpringing behavior. If the user wants to move a page at a time, they use the page up/down keys. If they're using the arrow keys, they're expecting to move a single item at a time. The previous/expected behavior is consistent with most applications, even web browsers. I can't recall any other application that behaves in the manner that you've changed sbbslist to behave.

digital man

This Is Spinal Tap quote #33:
Nigel Tufnel: Well, so what? What's wrong with bein' sexy?
Norco, CA WX: 58.3øF, 51.0% humidity, 7 mph ENE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sat Mar 28 2020 07:02 pm

That was intentional, for screen refresh optimizations. Rather than
re-draw the whole list every time you scroll one item, I thought it
would be more efficient to draw a whole page once, and then when you
move up or down, to only re-draw the lightbar for 2 items each time

It's surprising behavior (to me) for the arrow keys and I don't care for surpringing behavior. If the user wants to move a page at a time, they use the page up/down keys. If they're using the arrow keys, they're expecting to move a single item at a time. The previous/expected behavior is consistent with most applications, even web browsers. I can't recall any other application that behaves in the manner that you've changed sbbslist to behave.

True, I suppose.. Though at that point, it almost seems like it might as well be reverted back to 1.54. I'm sorry I didn't talk to you about changing it first, as I probably should have.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

exec sbbslist.js 1.64 1.65
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv15321

Modified Files:
sbbslist.js
Log Message:
When using the up arrow at the top of the page to scroll up one, or the bottom arrow at the bottom of the page to scroll down one, sbbslist now scrolls the list up/down one entry rather than the whole page of entries, to be consistent with earlier behavior (1.54 and earlier).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: Nightfox to Digital Man on Sat Mar 28 2020 08:37 pm

Re: exec/sbbslist.js
By: Digital Man to Nightfox on Sat Mar 28 2020 07:02 pm

That was intentional, for screen refresh optimizations. Rather than
re-draw the whole list every time you scroll one item, I thought it
would be more efficient to draw a whole page once, and then when you
move up or down, to only re-draw the lightbar for 2 items each time

It's surprising behavior (to me) for the arrow keys and I don't care for surpringing behavior. If the user wants to move a page at a time, they use the page up/down keys. If they're using the arrow keys, they're expecting to move a single item at a time. The previous/expected behavior is consistent with most applications, even web browsers. I can't recall any other application that behaves in the manner that you've changed sbbslist to behave.

True, I suppose.. Though at that point, it almost seems like it might as well be reverted back to 1.54. I'm sorry I didn't talk to you about changing it first, as I probably should have.

You did send me an email on this subject back in October, mainly in regards to the message lister, but I didn't reply.

Here's what I thought to myself when I read your email:
It's true that it's unnecessary to redraw all the items when just moving the selector up/down between 2 items that are already on the screen. That optimization is fine and good, but it's not a priority of mine right now. <shrug>

digital man

Synchronet/BBS Terminology Definition #59:
SBBS = Synchronet Bulletin Board System
Norco, CA WX: 53.0øF, 67.0% humidity, 6 mph E wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: exec/sbbslist.js
By: nightfox to CVS commit on Sat Mar 28 2020 09:42 pm

exec sbbslist.js 1.64 1.65
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv15321

Modified Files:
sbbslist.js
Log Message:
When using the up arrow at the top of the page to scroll up one, or the bottom arrow at the bottom of the page to scroll down one, sbbslist now scrolls the list up/down one entry rather than the whole page of entries, to be consistent with earlier behavior (1.54 and earlier).

Thank you. :-)

digital man

Synchronet/BBS Terminology Definition #49:
NNTP = Network News Transfer Protocol
Norco, CA WX: 50.0øF, 82.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec sbbslist.js 1.65 1.66
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv22942

Modified Files:
sbbslist.js
Log Message:
Cosmetics in the "<your system> is not lsited. Add it?" feature.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/435e79167fd306a2f55c731a
Modified Files:
exec/sbbslist.js
Log Message:
Add -force and -share options, handle missing protocol property.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/dc5da45735e41f1b985aad5c
Modified Files:
exec/sbbslist.js
Log Message:
Fix sbbslist.js line 1769: TypeError: bbs is undefined

Going backwards (negative) in the BBS list while using the 'C'
(preview capture) command would trigger this exception.

Also, don't enable spinning cursor while waiting for a key-press
after displaying a preview.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/86d0f05724d6baf59d53b14b
Modified Files:
exec/sbbslist.js
Log Message:
Fix a couple of infinite loops observed when user disconnected

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/22bf8731bc422f1b0361e7d0
Modified Files:
exec/sbbslist.js
Log Message:
Changes necessary to allow non-sbbs system to just sbbsimsg.lst

Use failed auto-verification server/service address info if/when
the 'imsg_capable' flag is set.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f7c8a5a91acd26a425efcd27
Modified Files:
exec/sbbslist.js
Log Message:
The command prompt is now always on the bottom of the screen (console.screen_rows).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cb66fc713bd4b1ed120c2a66
Modified Files:
exec/sbbslist.js
Log Message:
Merge branch '244_sbbslist_command_prompt_not_always_on_bottom' into 'master'

The command prompt is now always on the bottom of the screen

See merge request main/sbbs!121

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/08007ce1d0be3eaa7f324687
Modified Files:
exec/sbbslist.js
Log Message:
Remove storage from the 6th format, was making lines too long for 80cols.

And nobody cares about your terabytes of free space anyway.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/85fe6b4749f133aaf15a5b3e
Modified Files:
exec/sbbslist.js
Log Message:
Set default options.backup_level value (10)

Fixes issue #327.

Also remove some old obsolete comments.

Increment the REVISION value manually (no more CVS keywords).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f48239aa8dc362641994cdfa
Modified Files:
exec/sbbslist.js
Log Message:
Don't prompt yes/no upon remove if run with -quiet option

for Andre

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/045a33cafd1cd58b22b67399
Modified Files:
exec/sbbslist.js
Log Message:
Update logic for deciding if user can delete/edit entries

Local sysop can always deleted/edit entries (now).
Fixed checking of can_edit() return value (string or true), fixed issue #425
as reported by Craig Hendricks (thank you)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/353827c5687d226079e24866
Modified Files:
exec/sbbslist.js
Log Message:
Log the entire 'hello' object when detecting a non-Synchronet BBS

More detail to debug a false-negative SyncBBS-detection result

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c901c8dfe768af9dc6aba76c
Modified Files:
exec/sbbslist.js
Log Message:
Some old stil (SBL) messages might include 'address' before 'network'?

Attempt to address error reported by Manitoo in IRC:
JavaScript sbbslist.js line 327: TypeError: bbs.network[network] is undefined

Normally, the "address:" key would always follow a "network:" key, but maybe there's a corrupted message or the sysop is trying to import from the wrong message base (not syncdata?).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fabbad66cd65eeeabc0ef1fc
Modified Files:
exec/sbbslist.js
Log Message:
Add syncterm-ssh and syncterm-telnet commands

These prefer the protocol after the - and only include one listing
per BBS entry.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net