Hi DM,
With my JavaScript message reader, I've noticed I'm getting a weird error when I try to reply to a poll message. My reader allows voting, but I wanted to also reply to the poster of a poll message with some comments. My script calls bbs.post_msg() to post the reply, and I pass it the sub-board code, reply mode, and message header. On that line, I get the following error:
Error: can't convert 2147483648 to an integer
Just before that line, I tried having my script output the sub-board code, reply mode, and message header properties. The number that it was outputting appears to be the auxattr property of the message header. But when my script outputs that information, it generates a different error when it calls bbs.post_msg():
Error: line 865 js_ParseMsgHeaderObject js_msgbase.c JS_GetPrivate failed
So it seems something odd is going on if it gets a different error just by outputting some information before calling that function. The sub-board code looks right, and the reply mode value it's using is 64. I'm not sure what might be wrong. My reader doesn't have a problem replying to normal messages; this is only happening when replying to a poll message.
Re: Errors tryign to reply to a poll message
By: Nightfox to Digital Man on Wed Nov 01 2017 01:01 pm
Hi DM,
With my JavaScript message reader, I've noticed I'm getting a weird error when I try to reply to a poll message. My reader allows voting, but I wanted to also reply to the poster of a poll message with some comments. My script calls bbs.post_msg() to post the reply, and I pass it the sub-board code, reply mode, and message header. On that line, I get the following error:
Error: can't convert 2147483648 to an integer
Just before that line, I tried having my script output the sub-board code, reply mode, and message header properties. The number that it was outputting appears to be the auxattr property of the message header. But when my script outputs that information, it generates a different error when it calls bbs.post_msg():
Error: line 865 js_ParseMsgHeaderObject js_msgbase.c JS_GetPrivate failed
So it seems something odd is going on if it gets a different error just by outputting some information before calling that function. The sub-board code looks right, and the reply mode value it's using is 64. I'm not sure what might be wrong. My reader doesn't have a problem replying to normal messages; this is only happening when replying to a poll message.
Have you tried it with a different poll?
I suspect the problem is with a poll whose results are "closed" (not visible until the poll has been closed), as that sets bit 31 of the auxattr header field and there's an issue converting that in JS.
Have you tried it with a different poll?
I suspect the problem is with a poll whose results are "closed" (not visible until the poll has been closed), as that sets bit 31 of the auxattr header field and there's an issue converting that in JS.
The poll that showed the problem was a fairly recent poll, Mr. Cool's "What is >your preferred 1990's OS?" poll in Dove-Net General. I'm not sure the poll has
been closed.
I just committed what I hope is a fix. Please try it and let me know. I suspect this problem only occurs with polls whose results-visibility are set to "closed".
Re: Errors tryign to reply to a poll message
By: Digital Man to Nightfox on Wed Nov 01 2017 03:40 pm
I just committed what I hope is a fix. Please try it and let me know. I suspect this problem only occurs with polls whose results-visibility are set to "closed".
That seems to have fixed it.
I just committed what I hope is a fix. Please try it and let me
know. I suspect this problem only occurs with polls whose
results-visibility are set to "closed".
That seems to have fixed it.
Okay, cool. Thanks for the report. There are likely many other places in the Sync JS object where dealing with integers >= 0x80000000 would cause that error. It is strange you got a different error under different conditions, but the "auxattr" hint was what I needed to track this one done. Luckily, all the other SMB header field values don't use bit 31 (much).
I started noticing a lot of instances where sbbsctrl would crash when I tried replying to a message with my reader. It seemed to happen with any message (including regular messages). It didn't happen all the time, but a fairly high frequency (maybe 3 out of 4 times). I have reverted back to some earlier binaries I was using for now.
Some time ago I had tried building the Synchronet code in debug mode for instances like this where I see crashes, but I wasn't fully successful in getting it to build. Perhaps at some point I'll try again.
Some time ago I had tried building the Synchronet code in debug mode
for instances like this where I see crashes, but I wasn't fully
successful in getting it to build. Perhaps at some point I'll try
again.
That would be helpful. What version of MSVC were you using? Only MSVC 2013 is really supported right now.
Some time ago I had tried building the Synchronet code in debug mode
for instances like this where I see crashes, but I wasn't fully
successful in getting it to build. Perhaps at some point I'll try
again.
That would be helpful. What version of MSVC were you using? Only MSVC 2013 is really supported right now.
Some time ago I had tried building the Synchronet code in debug mode
for instances like this where I see crashes, but I wasn't fully
successful in getting it to build. Perhaps at some point I'll try
again.
That would be helpful. What version of MSVC were you using? Only MSVC 2013 is really supported right now.
Re: Errors tryign to reply to a poll message
By: Digital Man to Nightfox on Sat Nov 04 2017 02:10 am
Some time ago I had tried building the Synchronet code in debug mode
for instances like this where I see crashes, but I wasn't fully
successful in getting it to build. Perhaps at some point I'll try
again.
That would be helpful. What version of MSVC were you using? Only MSVC 2013 is really supported right now.
The wiki page says certain GUI components (such as sbbsctrl.exe) are built with Borland C++ Builder 6 and transitioning to Embarcadero Technologies C++ Builder:
http://wiki.synchro.net/dev:tools
Is that still accurate?
I think I was unsure of the process to build the
specific components with the different build tools. But if it can all be built with Visual Studio 2013, then I can give that a try.
Re: Errors tryign to reply to a poll message
By: Digital Man to Nightfox on Sat Nov 04 2017 02:10 am
Some time ago I had tried building the Synchronet code in debug mode
for instances like this where I see crashes, but I wasn't fully
successful in getting it to build. Perhaps at some point I'll try
again.
That would be helpful. What version of MSVC were you using? Only MSVC 2013 is really supported right now.
Tonight I downloaded Visual Studio 2013 Express and tried building the Synchronet source code. I loaded sbbs3.sln, and I noticed Visual Studio said it failed to load some projects - ftpsrvr, jsexec, mailsrvr, sbbs, services, and websrvr: http://www.digitaldistortionbbs.com/sbbsCodeBuilding/ProjectLoadFailures.png A separate issue - I imagine jsexec (and possibly other projects) may require some setup work to point it to the SpiderMonkey engine? Also I didn't see a sbbsctrl project in there (though the wiki notes that is built with Borland C++ Builder 6)..
Also, when I tried building the project, Visual Studio 2013 reported the following build errors: http://www.digitaldistortionbbs.com/sbbsCodeBuilding /buildFailures_vs2013.txt
Tonight I downloaded Visual Studio 2013 Express and tried building the
Synchronet source code. I loaded sbbs3.sln, and I noticed Visual
Studio said it failed to load some projects - ftpsrvr, jsexec,
mailsrvr, sbbs, services, and websrvr:
http://www.digitaldistortionbbs.com/sbbsCodeBuilding/ProjectLoadFailur
es.png A separate issue - I imagine jsexec (and possibly other
projects) may require some setup work to point it to the SpiderMonkey
engine? Also I didn't see a sbbsctrl project in there (though the
wiki notes that is built with Borland C++ Builder 6)..
Also, when I tried building the project, Visual Studio 2013 reported
the following build errors:
http://www.digitaldistortionbbs.com/sbbsCodeBuilding
/buildFailures_vs2013.txt
Did you download/extract the 3rdp directory from sbbs_src.zip?
Viewing .ZIP: s:/xfer/sbbs/sbbs_src.zip
Length Method Size Ratio Date Time CRC-32 Attr Name
------ ------ ----- ----- ---- ---- -------- ---- ----
843 DeflatX 395 53.2% 10/21/2011 4:29a a04c2560 --w---- 3rdp/win32.release/mozjs/mozjs.props
The "3rdp" directory should be extracted as a sibling directory of the "src" directory.
The "3rdp" directory should be extracted as a sibling directory of the "src" directory.
Ah, I hadn't done that. I gave that a try and was able to build the components with VS2013.
Ah, I hadn't done that. I gave that a try and was able to build the
components with VS2013.
Okay, good to hear.
Re: Errors tryign to reply to a poll message
By: Digital Man to Nightfox on Mon Nov 06 2017 12:09 pm
Ah, I hadn't done that. I gave that a try and was able to build the
components with VS2013.
Okay, good to hear.
After building the debug sbbs3 binaries, I copied them to a test machine, and when I tried running sbbsctrl.exe, I got the error "Incorrect SBBS.DLL version (0)". I tried copying sbbs.dll to C:\Windows\System32 but that didn't help. The test machine I was using has Windows 10 32-bit. Perhaps I should try with an earlier version of Windows?
After building the debug sbbs3 binaries, I copied them to a test
machine, and when I tried running sbbsctrl.exe, I got the error
"Incorrect SBBS.DLL version (0)". I tried copying sbbs.dll to
Anyway... as for the problem at hand: please try a a "release" build of the DLLs and see if you get the same error. If you do not get the error with the release DLLs (built by yourself), then I can probably get a copy of sbbsctrl.exe to you that will work with the debug DLLs (which is what you realliy want to run with).
But... there are alternatives to sbbsctrl.exe, like sbbs.exe and sbbsNTsvcs.exe. Have you tried those (built by yourself)?
Re: Errors tryign to reply to a poll message
By: Digital Man to Nightfox on Wed Nov 08 2017 10:16 pm
After building the debug sbbs3 binaries, I copied them to a test
machine, and when I tried running sbbsctrl.exe, I got the error
"Incorrect SBBS.DLL version (0)". I tried copying sbbs.dll to
Anyway... as for the problem at hand: please try a a "release" build of the DLLs and see if you get the same error. If you do not get the error with the release DLLs (built by yourself), then I can probably get a copy of sbbsctrl.exe to you that will work with the debug DLLs (which is what you realliy want to run with).
But... there are alternatives to sbbsctrl.exe, like sbbs.exe and sbbsNTsvcs.exe. Have you tried those (built by yourself)?
I built the release binaries but still got the same error, "Incorrect SBBS.DLL version (0)".
I was able to run sbbs.exe (rather than sbbsctrl.exe). I tried replying to several messages and it wasn't crashing.. This was on my test setup on Windows 10, and I'm wondering if that might make a difference. I'm still using Windows XP on my actual BBS machine - I've been thinking of upgrading it, and was going to use Windows 10, but the Windows 10 VM I created for it just seems a bit slow (though it seems to work).
I built the release binaries but still got the same error, "Incorrect
SBBS.DLL version (0)".
I was able to run sbbs.exe (rather than sbbsctrl.exe). I tried
replying to several messages and it wasn't crashing.. This was on my
test setup on Windows 10, and I'm wondering if that might make a
difference. I'm still using Windows XP on my actual BBS machine -
I've been thinking of upgrading it, and was going to use Windows 10,
but the Windows 10 VM I created for it just seems a bit slow (though
it seems to work).
I doubt Windows 10 vs XP is the difference maker. Do both setups share all the same configuration files?
| Sysop: | Tandy |
|---|---|
| Location: | New York, USA |
| Users: | 15 |
| Nodes: | 13 (0 / 13) |
| Uptime: | 03:59:48 |
| Calls: | 335 |
| Messages: | 112,921 |
